From 6207278bbf112fd0d36f0a93132896931f8d3605 Mon Sep 17 00:00:00 2001 From: Edison Su Date: Tue, 13 Dec 2011 17:23:28 -0800 Subject: [PATCH] fix meta data issue on direct tagged network, where router's public ip address is null --- .../network/router/VirtualNetworkApplianceManagerImpl.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java index 2c030be9b7a..afe99480041 100755 --- a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java +++ b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java @@ -705,7 +705,11 @@ public class VirtualNetworkApplianceManagerImpl implements VirtualNetworkApplian cmd.addVmData("metadata", "public-hostname", StringUtils.unicodeEscape(vmName)); }else { - cmd.addVmData("metadata", "public-ipv4", router.getPublicIpAddress()); + if (router.getPublicIpAddress() == null) { + cmd.addVmData("metadata", "public-ipv4", guestIpAddress); + } else { + cmd.addVmData("metadata", "public-ipv4", router.getPublicIpAddress()); + } cmd.addVmData("metadata", "public-hostname", router.getPublicIpAddress()); } cmd.addVmData("metadata", "instance-id", vmInstanceName);