From 627ef76fe1f58cc6c298b7b5d85adab70a306408 Mon Sep 17 00:00:00 2001 From: anthony Date: Mon, 25 Jun 2012 18:47:51 -0700 Subject: [PATCH] fix : ping command doesn't need to call syncNetworkGroups if security group is not enabled --- .../cloud/hypervisor/xen/resource/CitrixResourceBase.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java index 8f2d602397e..e6dc6f2603c 100644 --- a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java +++ b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java @@ -100,6 +100,7 @@ import com.cloud.agent.api.ModifyStoragePoolAnswer; import com.cloud.agent.api.ModifyStoragePoolCommand; import com.cloud.agent.api.NetworkRulesSystemVmCommand; import com.cloud.agent.api.PingCommand; +import com.cloud.agent.api.PingRoutingCommand; import com.cloud.agent.api.PingRoutingWithNwGroupsCommand; import com.cloud.agent.api.PingRoutingWithOvsCommand; import com.cloud.agent.api.PingTestCommand; @@ -4087,10 +4088,9 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe } } Connection conn = getConnection(); - /**if (!_canBridgeFirewall && !_isOvs) { + if (!_canBridgeFirewall && !_isOvs) { return new PingRoutingCommand(getType(), id, null); - } else**/ - if (_isOvs) { + } else if (_isOvs) { List>ovsStates = ovsFullSyncStates(); return new PingRoutingWithOvsCommand(getType(), id, null, ovsStates); }else {