From 6376503fe338496f3936fb10c2d6d30598e07023 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Tue, 7 Jul 2015 12:34:10 +0200 Subject: [PATCH] coverity 1308118: more resources being opened only one closed on exception nothing was closed Signed-off-by: Daan Hoogland --- .../xenserver/resource/CitrixResourceBase.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java index 48e721ffd17..71cc1149090 100644 --- a/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java +++ b/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java @@ -5052,12 +5052,11 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe } if (result && content != null && !content.isEmpty()) { - try { - final File file = new File(folder+"/"+fileName+".txt"); - final OutputStreamWriter fw = new OutputStreamWriter(new FileOutputStream(file.getAbsoluteFile()),"UTF-8"); - final BufferedWriter bw = new BufferedWriter(fw); + File file = new File(folder+"/"+fileName+".txt"); + try (OutputStreamWriter fw = new OutputStreamWriter(new FileOutputStream(file.getAbsoluteFile()),"UTF-8"); + BufferedWriter bw = new BufferedWriter(fw); + ) { bw.write(content); - bw.close(); s_logger.debug("created file: "+ file + " in folder:"+folder); } catch (final IOException ex) { s_logger.debug("Failed to create file "+ ex.getMessage());