etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

marvin_refactor: If there are no required arguments 

the else block isn't required.

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
This commit is contained in:
Prasanna Santhanam 2013-05-08 17:28:25 +05:30
parent 42c30f59a7
commit 65118c8f02
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/marvin/marvin/cs_entity_generator.py
View File

@ -243,9 +243,10 @@ def write_entity_classes(entities, module=None):
body.append(tabspace * 2 + 'if factory:')
body.append(
tabspace * 3 + '[setattr(cmd, factoryKey, factoryValue) for factoryKey, factoryValue in factory.__dict__.iteritems()]')
body.append(tabspace * 2 + 'else:')
for arg in details["args"]:
body.append(tabspace * 3 + "cmd.%s = %s" % (arg, arg))
if len(details["args"]) > 0:
body.append(tabspace * 2 + 'else:')
for arg in details["args"]:
body.append(tabspace * 3 + "cmd.%s = %s" % (arg, arg))
body.append(tabspace * 2 + '[setattr(cmd, key, value) for key, value in kwargs.iteritems()]')
body.append(tabspace * 2 + '%s = apiclient.%s(cmd)' % (entity.lower(), details['apimodule']))
body.append(