From 65f84f4321e4b1fd026f88c0845b3a0154bc3369 Mon Sep 17 00:00:00 2001
From: Naredula Janardhana Reddy <jana@cloud.com>
Date: Fri, 6 Jan 2012 20:04:14 +0530
Subject: [PATCH] bug 12917: security groups - icmp type/code validations.

---
 .../com/cloud/network/security/SecurityGroupManagerImpl.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/server/src/com/cloud/network/security/SecurityGroupManagerImpl.java b/server/src/com/cloud/network/security/SecurityGroupManagerImpl.java
index b168c7bd115..e117042fb33 100755
--- a/server/src/com/cloud/network/security/SecurityGroupManagerImpl.java
+++ b/server/src/com/cloud/network/security/SecurityGroupManagerImpl.java
@@ -601,7 +601,10 @@ public class SecurityGroupManagerImpl implements SecurityGroupManager, SecurityG
                 throw new InvalidParameterValueException("Invalid ICMP type/code specified, icmpType = " + icmpType + ", icmpCode = " + icmpCode);
             }
             if (icmpType == -1 && icmpCode != -1) {
-                throw new InvalidParameterValueException("Invalid icmp type range");
+                throw new InvalidParameterValueException("Invalid icmp code");
+            }
+            if (icmpType != -1 && icmpCode == -1) {
+                throw new InvalidParameterValueException("Invalid icmp code: need not negative icmp code ");
             }
             if (icmpCode > 255 || icmpType > 255 || icmpCode < -1 || icmpType < -1) {
                 throw new InvalidParameterValueException("Invalid icmp type/code ");