From 665142701d5532e42dfcabbbccdc55c24495463a Mon Sep 17 00:00:00 2001
From: Pearl Dsilva <pearl1594@gmail.com>
Date: Mon, 5 Jul 2021 11:50:10 +0530
Subject: [PATCH] server: Fix NPE when no recipients configured for sending
 alerts (#5154)

* Fix NPE when no recipients configured for sending alerts

* Adding logs

* Address comments
---
 server/src/main/java/com/cloud/alert/AlertManagerImpl.java | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
index 99200f41c2a..f6e4360b981 100644
--- a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
+++ b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
@@ -712,6 +712,11 @@ public class AlertManagerImpl extends ManagerBase implements AlertManager, Confi
             return;
         }
 
+        if (recipients == null) {
+            s_logger.warn(String.format("No recipients set in 'alert.email.addresses', skipping sending alert with subject: %s and content: %s", subject, content));
+            return;
+        }
+
         SMTPMailProperties mailProps = new SMTPMailProperties();
         mailProps.setSender(new MailAddress(senderAddress));
         mailProps.setSubject(subject);