From 68027ead88d8911209523d0dc660706dec59abb7 Mon Sep 17 00:00:00 2001 From: Pearl Dsilva Date: Tue, 16 Jan 2024 08:19:01 -0500 Subject: [PATCH] address comments --- .../api/command/admin/network/CreateNetworkOfferingCmd.java | 4 ++-- .../api/command/admin/vpc/CreateVPCOfferingCmd.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java index 36c5b8c5346..e2ae2b42861 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java @@ -255,7 +255,7 @@ public class CreateNetworkOfferingCmd extends BaseCmd { PortForwarding.getName(), UserData.getName() )); - if (Boolean.TRUE.equals(getNsxSupportsLbService())) { + if (getNsxSupportsLbService()) { services.add(Lb.getName()); } if (Boolean.TRUE.equals(forVpc)) { @@ -368,7 +368,7 @@ public class CreateNetworkOfferingCmd extends BaseCmd { serviceProviderMap.put(service, List.of(routerProvider)); else serviceProviderMap.put(service, List.of(Network.Provider.Nsx.getName())); - if (Boolean.FALSE.equals(getNsxSupportsLbService())) { + if (!getNsxSupportsLbService()) { serviceProviderMap.remove(Lb.getName()); } } diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java index 26a6d821e44..43c8838670d 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java @@ -164,7 +164,7 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd { PortForwarding.getName(), UserData.getName() )); - if (Boolean.TRUE.equals(getNsxSupportsLbService())) { + if (getNsxSupportsLbService()) { supportedServices.add(Lb.getName()); } } @@ -225,7 +225,7 @@ public class CreateVPCOfferingCmd extends BaseAsyncCreateCmd { else serviceProviderMap.put(service, List.of(Network.Provider.Nsx.getName())); } - if (Boolean.FALSE.equals(getNsxSupportsLbService())) { + if (!getNsxSupportsLbService()) { serviceProviderMap.remove(Lb.getName()); } }