diff --git a/utils/src/org/apache/cloudstack/utils/graphite/GraphiteClient.java b/utils/src/org/apache/cloudstack/utils/graphite/GraphiteClient.java index 6fbd4c30ade..3338ccf213f 100644 --- a/utils/src/org/apache/cloudstack/utils/graphite/GraphiteClient.java +++ b/utils/src/org/apache/cloudstack/utils/graphite/GraphiteClient.java @@ -78,17 +78,14 @@ public class GraphiteClient { * @param timeStamp the timestamp */ public void sendMetrics(Map metrics, long timeStamp) { - try { - DatagramSocket sock = new DatagramSocket(); - InetAddress addr = InetAddress.getByName(graphiteHost); + try (DatagramSocket sock = new DatagramSocket()){ + InetAddress addr = InetAddress.getByName(this.graphiteHost); for (Map.Entry metric: metrics.entrySet()) { byte[] message = new String(metric.getKey() + " " + metric.getValue() + " " + timeStamp + "\n").getBytes(); DatagramPacket packet = new DatagramPacket(message, message.length, addr, graphitePort); sock.send(packet); } - - sock.close(); } catch (UnknownHostException e) { throw new GraphiteException("Unknown host: " + graphiteHost); } catch (IOException e) { @@ -122,4 +119,4 @@ public class GraphiteClient { metrics.put(key, value); sendMetrics(metrics, timeStamp); } -} \ No newline at end of file +}