From 6bccf5ff41ee2177ca081ea8eb9f9bf9bbe256ce Mon Sep 17 00:00:00 2001 From: Santhosh Edukulla Date: Wed, 6 Aug 2014 17:28:49 +0530 Subject: [PATCH] Fixed coverity reported concurrency issues --- agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java b/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java index c573f29b843..08c80497eff 100755 --- a/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java +++ b/agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java @@ -66,7 +66,7 @@ public class PropertiesStorage implements StorageComponent { } @Override - public boolean configure(String name, Map params) { + public synchronized boolean configure(String name, Map params) { _name = name; String path = (String)params.get("path"); if (path == null) { @@ -86,7 +86,6 @@ public class PropertiesStorage implements StorageComponent { return false; } } - try { PropertiesUtil.loadFromFile(_properties, file); _file = file; @@ -97,7 +96,6 @@ public class PropertiesStorage implements StorageComponent { s_logger.error("IOException: ", e); return false; } - return true; }