From 6c1dde8f8632798c8059af27d68cf90209fff284 Mon Sep 17 00:00:00 2001
From: Rohit Yadav <rohit.yadav@shapeblue.com>
Date: Mon, 1 Jun 2015 14:10:54 +0200
Subject: [PATCH] schema: Encode URL safe random vnc password string

/+= may break on some environments, url safe encoded passwords will have -_,
characters which are more acceptable

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 19cc5eb9e6f1b5127bf01e4c1ae061875e61cb4c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
---
 engine/schema/src/com/cloud/vm/VMInstanceVO.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/engine/schema/src/com/cloud/vm/VMInstanceVO.java b/engine/schema/src/com/cloud/vm/VMInstanceVO.java
index 8f42a4307db..d4b18d078e4 100644
--- a/engine/schema/src/com/cloud/vm/VMInstanceVO.java
+++ b/engine/schema/src/com/cloud/vm/VMInstanceVO.java
@@ -210,7 +210,7 @@ public class VMInstanceVO implements VirtualMachine, FiniteStateObject<State, Vi
             SecureRandom random = SecureRandom.getInstance("SHA1PRNG");
             byte[] randomBytes = new byte[16];
             random.nextBytes(randomBytes);
-            vncPassword = Base64.encodeBase64String(randomBytes);
+            vncPassword = Base64.encodeBase64URLSafeString(randomBytes);
         } catch (NoSuchAlgorithmException e) {
             s_logger.error("Unexpected exception in SecureRandom Algorithm selection ", e);
         }