From 6c436ec90e2b89d33ce9da6f988c44a9c8df6467 Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Fri, 25 Nov 2022 14:19:16 +0530 Subject: [PATCH] server: fix domain shared public template check (#6916) Fixes #6885 Fixes the incorrect inverted check. Signed-off-by: Abhishek Kumar Signed-off-by: Abhishek Kumar --- server/src/main/java/com/cloud/acl/DomainChecker.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/main/java/com/cloud/acl/DomainChecker.java b/server/src/main/java/com/cloud/acl/DomainChecker.java index bf7bd52ece7..a8c9ab84f7e 100644 --- a/server/src/main/java/com/cloud/acl/DomainChecker.java +++ b/server/src/main/java/com/cloud/acl/DomainChecker.java @@ -120,7 +120,7 @@ public class DomainChecker extends AdapterBase implements SecurityChecker { */ private void checkPublicTemplateAccess(VirtualMachineTemplate template, Account owner, Account caller){ - if (!QueryService.SharePublicTemplatesWithOtherDomains.valueIn(owner.getDomainId()) || + if (QueryService.SharePublicTemplatesWithOtherDomains.valueIn(owner.getDomainId()) || caller.getDomainId() == owner.getDomainId() || _domainDao.isChildDomain(owner.getDomainId(), caller.getDomainId())) { return;