From 6f2fb9236490a45c120a0d767eae6833a03cc456 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Sun, 12 Apr 2015 20:27:23 +0200 Subject: [PATCH] findbugs: .equals() on wrapper class --- .../src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java b/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java index 455535f5e28..676275a1f5c 100644 --- a/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java +++ b/plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfUtils.java @@ -380,7 +380,7 @@ public class BigSwitchBcfUtils { Integer port = rule.getSourcePortStart(); fwCidrList = _fwCidrsDao.listByFirewallRuleId(rule.getId()); if(fwCidrList != null){ - if(fwCidrList.size()>1 || rule.getSourcePortEnd()!=port){ + if (fwCidrList.size() > 1 || !rule.getSourcePortEnd().equals(port)) { continue; } else { cidr = fwCidrList.get(0).getCidr(); @@ -414,7 +414,7 @@ public class BigSwitchBcfUtils { Integer port = item.getSourcePortStart(); // currently BCF supports single port policy aclCidrList = _aclItemCidrsDao.listByNetworkACLItemId(item.getId()); if(aclCidrList != null){ - if(aclCidrList.size()>1 || item.getSourcePortEnd()!=port){ + if (aclCidrList.size() > 1 || !item.getSourcePortEnd().equals(port)) { continue; } else { cidr = aclCidrList.get(0).getCidr();