diff --git a/api/src/main/java/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java b/api/src/main/java/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java index 6b31c4cc43c..e65326cd874 100644 --- a/api/src/main/java/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java +++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java @@ -132,14 +132,16 @@ public class ListCapacityCmd extends BaseListCmd { Collections.sort(capacityResponses, new Comparator() { public int compare(CapacityResponse resp1, CapacityResponse resp2) { int res = resp1.getZoneName().compareTo(resp2.getZoneName()); + // Group by zone if (res != 0) { return res; - } else { - return resp1.getCapacityType().compareTo(resp2.getCapacityType()); } + // Sort by capacity type only if not already sorted by usage + return (getSortBy() != null) ? 0 : resp1.getCapacityType().compareTo(resp2.getCapacityType()); } }); + response.setResponses(capacityResponses); response.setResponseName(getCommandName()); this.setResponseObject(response); diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java index f0911ba4ea4..ec4a06ae022 100644 --- a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java +++ b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java @@ -249,9 +249,7 @@ public class LibvirtVMDef { guestDef.append("\n"); } } - if (_arch == null || ! (_arch.equals("aarch64") || _arch.equals("s390x"))) { // simplification of (as ref.) (!(_arch != null && _arch.equals("s390x")) || (_arch == null || !_arch.equals("aarch64"))) - guestDef.append("\n"); - } + guestDef.append("\n"); guestDef.append("\n"); if (iothreads) { guestDef.append(String.format("%s", NUMBER_OF_IOTHREADS)); diff --git a/server/src/main/java/com/cloud/network/NetworkServiceImpl.java b/server/src/main/java/com/cloud/network/NetworkServiceImpl.java index d0f0e893a10..2554435a787 100644 --- a/server/src/main/java/com/cloud/network/NetworkServiceImpl.java +++ b/server/src/main/java/com/cloud/network/NetworkServiceImpl.java @@ -5703,7 +5703,6 @@ public class NetworkServiceImpl extends ManagerBase implements NetworkService, C } addProviderToPhysicalNetwork(physicalNetworkId, Provider.Nsx.getName(), null, null); - enableProvider(Provider.Nsx.getName()); } return null; } diff --git a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue index 1286967643c..16d384e5288 100644 --- a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue +++ b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue @@ -1098,6 +1098,7 @@ export default { providerParams.transportzone = this.prefillContent?.transportZone || '' await this.addNsxController(providerParams) + await this.updateNsxServiceProviderStatus() this.stepData.stepMove.push('addNsxController') } this.stepData.stepMove.push('nsx') @@ -1108,6 +1109,18 @@ export default { this.setStepStatus(STATUS_FAILED) } }, + async updateNsxServiceProviderStatus () { + const listParams = {} + listParams.name = 'Nsx' + const nsxPhysicalNetwork = this.stepData.physicalNetworksReturned.find(net => net.isolationmethods.trim().toUpperCase() === 'NSX') + const nsxPhysicalNetworkId = nsxPhysicalNetwork?.id || null + listParams.physicalNetworkId = nsxPhysicalNetworkId + const nsxProviderId = await this.listNetworkServiceProviders(listParams, 'nsxProvider') + console.log(nsxProviderId) + if (nsxProviderId !== null) { + await this.updateNetworkServiceProvider(nsxProviderId) + } + }, async stepAddNetrisProvider () { this.setStepStatus(STATUS_FINISH) this.currentStep++