etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CID 1264632: Rely on a known and widely available encoding UTF8 

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 0763b5576d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This commit is contained in:
Rohit Yadav 2015-01-20 07:47:34 +05:30
parent 7699c70ade
commit 70f9db34cb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
utils/src/com/cloud/utils/ConstantTimeComparator.java
View File

@ -19,6 +19,8 @@
package com.cloud.utils;
import java.nio.charset.Charset;
public class ConstantTimeComparator {
public static boolean compareBytes(byte[] b1, byte[] b2) {
@ -34,6 +36,7 @@ public class ConstantTimeComparator {
}
public static boolean compareStrings(String s1, String s2) {
return compareBytes(s1.getBytes(), s2.getBytes());
final Charset encoding = Charset.forName("UTF-8");
return compareBytes(s1.getBytes(encoding), s2.getBytes(encoding));
}
}