From 71b36e8ff70583df676a089a3c334b465f4eb70d Mon Sep 17 00:00:00 2001 From: Min Chen Date: Fri, 16 Aug 2013 10:46:22 -0700 Subject: [PATCH] CLOUDSTACK-3274: Remove duplicate cleanString calls in logging api for performance improvement. --- server/src/com/cloud/api/ApiServer.java | 2 +- server/src/com/cloud/api/ApiServlet.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java index 42d3e6a5cc5..9a6f6e41db2 100755 --- a/server/src/com/cloud/api/ApiServer.java +++ b/server/src/com/cloud/api/ApiServer.java @@ -314,7 +314,7 @@ public class ApiServer extends ManagerBase implements HttpRequestHandler, ApiSer throw e; } } finally { - s_accessLogger.info(StringUtils.cleanString(sb.toString())); + s_accessLogger.info(sb.toString()); UserContext.unregisterContext(); } } diff --git a/server/src/com/cloud/api/ApiServlet.java b/server/src/com/cloud/api/ApiServlet.java index fa02041f6a5..ca6f4b46806 100755 --- a/server/src/com/cloud/api/ApiServlet.java +++ b/server/src/com/cloud/api/ApiServlet.java @@ -119,8 +119,8 @@ public class ApiServlet extends HttpServlet { // logging the request start and end in management log for easy debugging String reqStr = ""; if (s_logger.isDebugEnabled()) { - reqStr = auditTrailSb.toString() + " " + req.getQueryString(); - s_logger.debug("===START=== " + StringUtils.cleanString(reqStr)); + reqStr = auditTrailSb.toString() + " " + StringUtils.cleanString(req.getQueryString()); + s_logger.debug("===START=== " + reqStr); } try { @@ -326,9 +326,9 @@ public class ApiServlet extends HttpServlet { s_logger.error("unknown exception writing api response", ex); auditTrailSb.append(" unknown exception writing api response"); } finally { - s_accessLogger.info(StringUtils.cleanString(auditTrailSb.toString())); + s_accessLogger.info(auditTrailSb.toString()); if (s_logger.isDebugEnabled()) { - s_logger.debug("===END=== " + StringUtils.cleanString(reqStr)); + s_logger.debug("===END=== " + reqStr); } // cleanup user context to prevent from being peeked in other request context UserContext.unregisterContext();