From 72f967aa6d6591d61dcfcc2756f019c40eb3edde Mon Sep 17 00:00:00 2001
From: jmsperu <jmsperu@users.noreply.github.com>
Date: Tue, 5 May 2026 11:23:20 +0300
Subject: [PATCH] test(backup): mock BackupDetailsDao to fix NPE in
 NASBackupProviderTest

Adds @Mock injection for BackupDetailsDao so NASBackupProvider's
backupDetailsDao field is wired during testDeleteBackup and
takeBackupSuccessfully, fixing the NPE flagged by @harikrishna-patnala.
---
 .../org/apache/cloudstack/backup/NASBackupProviderTest.java   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java b/plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java
index a512292cd28..5a44562c583 100644
--- a/plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java
+++ b/plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java
@@ -52,6 +52,7 @@ import com.cloud.vm.VMInstanceVO;
 import com.cloud.vm.dao.VMInstanceDao;
 
 import org.apache.cloudstack.backup.dao.BackupDao;
+import org.apache.cloudstack.backup.dao.BackupDetailsDao;
 import org.apache.cloudstack.backup.dao.BackupRepositoryDao;
 import org.apache.cloudstack.backup.dao.BackupOfferingDao;
 import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
@@ -96,6 +97,9 @@ public class NASBackupProviderTest {
     @Mock
     private VMSnapshotDao vmSnapshotDaoMock;
 
+    @Mock
+    private BackupDetailsDao backupDetailsDao;
+
     @Test
     public void testDeleteBackup() throws OperationTimedoutException, AgentUnavailableException {
         Long hostId = 1L;