diff --git a/engine/components-api/src/com/cloud/vm/VmWorkJobHandlerProxy.java b/engine/components-api/src/com/cloud/vm/VmWorkJobHandlerProxy.java index ce10a83c7cd..574e60f1455 100644 --- a/engine/components-api/src/com/cloud/vm/VmWorkJobHandlerProxy.java +++ b/engine/components-api/src/com/cloud/vm/VmWorkJobHandlerProxy.java @@ -116,10 +116,8 @@ public class VmWorkJobHandlerProxy implements VmWorkJobHandler { // legacy CloudStack code relies on checked exception for error handling // we need to re-throw the real exception here - if (e.getCause() != null && e.getCause() instanceof Exception) { - s_logger.info("Rethrow exception " + e.getCause()); + if (e.getCause() != null && e.getCause() instanceof Exception) throw (Exception)e.getCause(); - } throw e; } diff --git a/engine/orchestration/src/com/cloud/vm/VmWorkJobWakeupDispatcher.java b/engine/orchestration/src/com/cloud/vm/VmWorkJobWakeupDispatcher.java index 5704f978720..520a55042e3 100644 --- a/engine/orchestration/src/com/cloud/vm/VmWorkJobWakeupDispatcher.java +++ b/engine/orchestration/src/com/cloud/vm/VmWorkJobWakeupDispatcher.java @@ -40,6 +40,12 @@ import com.cloud.user.dao.AccountDao; import com.cloud.utils.component.AdapterBase; import com.cloud.vm.dao.VMInstanceDao; +/** + * Please note: VmWorkJobWakeupDispatcher is not currently in use. It is designed for event-driven based + * job processing model. + * + * Current code base uses blocking calls to wait for job completion + */ public class VmWorkJobWakeupDispatcher extends AdapterBase implements AsyncJobDispatcher { private static final Logger s_logger = Logger.getLogger(VmWorkJobWakeupDispatcher.class); diff --git a/server/src/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/com/cloud/storage/VolumeApiServiceImpl.java index 179a10c63d7..f453289b455 100644 --- a/server/src/com/cloud/storage/VolumeApiServiceImpl.java +++ b/server/src/com/cloud/storage/VolumeApiServiceImpl.java @@ -2360,7 +2360,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic return new Pair(JobInfo.Status.SUCCEEDED, null); } - private Pair orchestrateDetachVolumeFromVM(VmWorkAttachVolume work) throws Exception { + private Pair orchestrateDetachVolumeFromVM(VmWorkDetachVolume work) throws Exception { orchestrateDetachVolumeFromVM(work.getVmId(), work.getVolumeId()); return new Pair(JobInfo.Status.SUCCEEDED, null); }