diff --git a/engine/schema/src/main/java/com/cloud/projects/dao/ProjectAccountDaoImpl.java b/engine/schema/src/main/java/com/cloud/projects/dao/ProjectAccountDaoImpl.java index ea604720a5d..d2ba49e9408 100644 --- a/engine/schema/src/main/java/com/cloud/projects/dao/ProjectAccountDaoImpl.java +++ b/engine/schema/src/main/java/com/cloud/projects/dao/ProjectAccountDaoImpl.java @@ -23,6 +23,7 @@ import org.springframework.stereotype.Component; import com.cloud.projects.ProjectAccount; import com.cloud.projects.ProjectAccountVO; +import com.cloud.utils.db.Filter; import com.cloud.utils.db.GenericDaoBase; import com.cloud.utils.db.GenericSearchBuilder; import com.cloud.utils.db.SearchBuilder; @@ -96,8 +97,8 @@ public class ProjectAccountDaoImpl extends GenericDaoBase listByProjectId(long projectId) { SearchCriteria sc = AllFieldsSearch.create(); sc.setParameters("projectId", projectId); - - return listBy(sc); + Filter filter = new Filter(ProjectAccountVO.class, "id", Boolean.TRUE, null, null); + return listBy(sc, filter); } @Override diff --git a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java index 543c9772d7c..2fd8cb94418 100644 --- a/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java +++ b/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java @@ -675,11 +675,9 @@ public class CapacityManagerImpl extends ManagerBase implements CapacityManager, Map vmDetails = _userVmDetailsDao.listDetailsKeyPairs(vm.getId()); String vmDetailCpu = vmDetails.get("cpuOvercommitRatio"); String vmDetailRam = vmDetails.get("memoryOvercommitRatio"); - if (vmDetailCpu != null) { - //if vmDetail_cpu is not null it means it is running in a overcommited cluster. - cpuOvercommitRatio = Float.parseFloat(vmDetailCpu); - ramOvercommitRatio = Float.parseFloat(vmDetailRam); - } + // if vmDetailCpu or vmDetailRam is not null it means it is running in a overcommitted cluster. + cpuOvercommitRatio = (vmDetailCpu != null) ? Float.parseFloat(vmDetailCpu) : clusterCpuOvercommitRatio; + ramOvercommitRatio = (vmDetailRam != null) ? Float.parseFloat(vmDetailRam) : clusterRamOvercommitRatio; ServiceOffering so = offeringsMap.get(vm.getServiceOfferingId()); if (so == null) { so = _offeringsDao.findByIdIncludingRemoved(vm.getServiceOfferingId()); diff --git a/server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java b/server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java index 3cbb5f4b99e..622a4c84761 100644 --- a/server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java +++ b/server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java @@ -495,8 +495,10 @@ public class ConsoleProxyServlet extends HttpServlet { if (param.getHypervHost() != null || !ConsoleProxyManager.NoVncConsoleDefault.value()) { sb.append("/ajax?token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param)); } else { - sb.append("/resource/noVNC/vnc.html?port=" + ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token=" - + encryptor.encryptObject(ConsoleProxyClientParam.class, param)); + sb.append("/resource/noVNC/vnc.html") + .append("?autoconnect=true") + .append("&port=" + ConsoleProxyManager.DEFAULT_NOVNC_PORT) + .append("&token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param)); } // for console access, we need guest OS type to help implement keyboard diff --git a/systemvm/agent/noVNC/app/styles/base.css b/systemvm/agent/noVNC/app/styles/base.css index fd78b79c772..c0e99b84003 100644 --- a/systemvm/agent/noVNC/app/styles/base.css +++ b/systemvm/agent/noVNC/app/styles/base.css @@ -672,6 +672,10 @@ select:active { max-width: 100%; } +:root:not(.noVNC_connected) #noVNC_fullscreen_button { + display: none; +} + /* Settings */ #noVNC_settings { } diff --git a/systemvm/agent/noVNC/vnc.html b/systemvm/agent/noVNC/vnc.html index a244a7df82e..04c00291abb 100644 --- a/systemvm/agent/noVNC/vnc.html +++ b/systemvm/agent/noVNC/vnc.html @@ -333,9 +333,4 @@ - diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json index 39d21366765..5010e329ac3 100644 --- a/ui/public/locales/en.json +++ b/ui/public/locales/en.json @@ -202,6 +202,8 @@ "label.action.generate.keys": "Generate Keys", "label.action.generate.keys.processing": "Generate Keys....", "label.action.get.diagnostics": "Get Diagnostics Data", +"label.action.image.store.read.only": "Make Image store read-only", +"label.action.image.store.read.write": "Make Image store read-write", "label.action.iso.permission": "Update ISO Permissions", "label.action.iso.share": "Update ISO Sharing", "label.action.list.nexusvswitch": "List Nexus 1000v", @@ -2438,6 +2440,8 @@ "message.action.revert.snapshot": "Please confirm that you want to revert the owning volume to this snapshot.", "message.action.router.health.checks": "Health checks result will be fetched from router.", "message.action.router.health.checks.disabled.warning": "Please enable router health checks.", +"message.action.secondary.storage.read.only": "Please confirm that you want to make this secondary storage read only.", +"message.action.secondary.storage.read.write": "Please confirm that you want to make this secondary storage read write.", "message.action.secure.host": "This will restart the host agent and libvirtd process after applying new X509 certificates, please confirm?", "message.action.settings.warning.vm.running": "Please stop the virtual machine to access settings", "message.action.settings.warning.vm.started": "Virtual machine has been started. It needs to be stopped to access settings", @@ -3057,7 +3061,7 @@ "message.restart.mgmt.usage.server": "Please restart your management server(s) and usage server(s) for your new settings to take effect.", "message.restart.network": "All services provided by this network will be interrupted. Please confirm that you want to restart this network.", "message.restart.vpc": "Please confirm that you want to restart the VPC", -"message.restart.vpc.remark": "Please confirm that you want to restart the VPC

Remark: making a non-redundant VPC redundant will force a clean up. The networks will not be available for a couple of minutes.

", +"message.restart.vpc.remark": "Please confirm that you want to restart the VPC

Remark: making a non-redundant VPC redundant will force a clean up. The networks will not be available for a couple of minutes.

", "message.restorevm": "Do you want to restore the VM ?", "message.role.ordering.fail": "Reordering of rule permissions aborted as the list has changed while you were making changes. Please try again.", "message.role.update.fail": "Failed updating rule permission", @@ -3191,6 +3195,7 @@ "message.update.ipaddress.processing": "Updating IP Address...", "message.update.os.preference": "Please choose a OS preference for this host. All virtual instances with similar preferences will be first allocated to this host before choosing another.", "message.update.resource.count": "Please confirm that you want to update resource counts for this account.", +"message.update.resource.count.domain": "Please confirm that you want to update resource counts for this domain.", "message.update.ssl": "Please submit a new X.509 compliant SSL certificate chain to be updated to each console proxy and secondary storage virtual instance:", "message.update.ssl.failed": "Failed to update SSL Certificate.", "message.update.ssl.succeeded": "Update SSL Certificates succeeded", diff --git a/ui/src/components/view/ActionButton.vue b/ui/src/components/view/ActionButton.vue index 570dae1b205..4f205900d56 100644 --- a/ui/src/components/view/ActionButton.vue +++ b/ui/src/components/view/ActionButton.vue @@ -17,7 +17,12 @@