From 78507c07c8189e10762edd129a7385bc4aaa8eef Mon Sep 17 00:00:00 2001 From: Laszlo Hornyak Date: Wed, 30 Apr 2014 21:20:31 +0200 Subject: [PATCH] log exceptions in ConsoleProxyServlet - Added exception to the logger method parameters to make stack trace available - removed checking of debug level, it does not save temporary object creation here Signed-off-by: Laszlo Hornyak --- server/src/com/cloud/servlet/ConsoleProxyServlet.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/server/src/com/cloud/servlet/ConsoleProxyServlet.java b/server/src/com/cloud/servlet/ConsoleProxyServlet.java index 16d7a3292fe..ff8453b4361 100644 --- a/server/src/com/cloud/servlet/ConsoleProxyServlet.java +++ b/server/src/com/cloud/servlet/ConsoleProxyServlet.java @@ -237,9 +237,7 @@ public class ConsoleProxyServlet extends HttpServlet { try { resp.sendRedirect(composeThumbnailUrl(rootUrl, vm, host, w, h)); } catch (IOException e) { - if (s_logger.isInfoEnabled()) { - s_logger.info("Client may already close the connection"); - } + s_logger.info("Client may already close the connection", e); } } @@ -501,9 +499,7 @@ public class ConsoleProxyServlet extends HttpServlet { resp.setContentType("text/html"); resp.getWriter().print(content); } catch (IOException e) { - if (s_logger.isInfoEnabled()) { - s_logger.info("Client may already close the connection"); - } + s_logger.info("Client may already close the connection", e); } }