etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt" refers to. 

Signed-off-by: Koushik Das <koushik@apache.org>
This commit is contained in:
Rajani Karuturi 2014-06-03 16:11:01 +05:30 committed by Koushik Das
parent 2424d9a9e0
commit 793462e5fa
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java
View File

@ -130,18 +130,20 @@ public class Upgrade421to430 implements DbUpgrade {
try {
pstmt = conn.prepareStatement(insertSql);
for (String[] ldapParam : ldapParams) {
String name = ldapParam[0];
String value = ldapParam[1];
String desc = ldapParam[2];
String encryptedValue = DBEncryptionUtil.encrypt(value);
pstmt = conn.prepareStatement(insertSql);
pstmt.setString(1, name);
pstmt.setBytes(2, encryptedValue.getBytes("UTF-8"));
pstmt.setString(3, desc);
pstmt.executeUpdate();
}
pstmt.close();
/**
* if encrypted, decrypt the ldap hostname and port and then update as they are not encrypted now.
*/
@ -154,6 +156,8 @@ public class Upgrade421to430 implements DbUpgrade {
hostname = DBEncryptionUtil.decrypt(resultSet.getString(1));
}
pstmt.close();
pstmt = conn.prepareStatement("SELECT conf.value FROM `cloud`.`configuration` conf WHERE conf.name='ldap.port'");
resultSet = pstmt.executeQuery();
if (resultSet.next()) {
@ -162,6 +166,7 @@ public class Upgrade421to430 implements DbUpgrade {
portNumber = Integer.valueOf(port);
}
}
pstmt.close();
if (StringUtils.isNotBlank(hostname)) {
pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)");
@ -172,6 +177,7 @@ public class Upgrade421to430 implements DbUpgrade {
pstmt.setNull(2, Types.INTEGER);
}
pstmt.executeUpdate();
pstmt.close();
}
} catch (SQLException e) {