From 7aeb5b081048b2c5ca81c63e7afe8640edc839ef Mon Sep 17 00:00:00 2001 From: Codegass Date: Mon, 28 Nov 2022 10:06:50 -0500 Subject: [PATCH] Simplify Test Case ApplicationLoadBalancerTest.searchForNonExistingLoadBalancer (#6882) --- .../network/lb/ApplicationLoadBalancerTest.java | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/server/src/test/java/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java b/server/src/test/java/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java index 939293ed15b..b246855c289 100644 --- a/server/src/test/java/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java +++ b/server/src/test/java/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java @@ -186,22 +186,11 @@ public class ApplicationLoadBalancerTest extends TestCase { assertNotNull("Couldn't find existing application load balancer", rule); } - @Test + @Test(expected = InvalidParameterValueException.class) //Negative test - try to retrieve non-existing lb public - void searchForNonExistingLoadBalancer() { - boolean notFound = false; - ApplicationLoadBalancerRule rule = null; - try { - rule = _appLbSvc.getApplicationLoadBalancer(nonExistingLbId); - if (rule != null) { - notFound = false; - } - } catch (InvalidParameterValueException ex) { - notFound = true; - } - - assertTrue("Found non-existing load balancer; no invalid parameter value exception was thrown", notFound); + void searchForNonExistingLoadBalancer() throws InvalidParameterValueException { + _appLbSvc.getApplicationLoadBalancer(nonExistingLbId); } /**