From 7b105917584da7cc0ad4cd9a3e6391c6ae433c78 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Wed, 29 Apr 2015 16:07:38 +0200 Subject: [PATCH] findbugs: String.split() will not return nulls by contract --- .../cloud/hypervisor/kvm/resource/LibvirtComputingResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java index 06b7614f617..6debb8567eb 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java @@ -867,7 +867,7 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv if (cpuFeatures != null) { _cpuFeatures = new ArrayList(); for (String feature: cpuFeatures.split(" ")) { - if (feature != null || !feature.isEmpty()) { + if (!feature.isEmpty()) { _cpuFeatures.add(feature); } }