Fix the path for the API server endpoint.

RB: https://reviews.apache.org/r/6513/

Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>
This commit is contained in:
Edison Su 2012-08-10 10:17:54 -07:00
parent b9e1cb640a
commit 81727ad18d
1 changed files with 28 additions and 28 deletions

View File

@ -5,9 +5,9 @@
# to you under the Apache License, Version 2.0 (the # to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance # "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at # with the License. You may obtain a copy of the License at
# #
# http://www.apache.org/licenses/LICENSE-2.0 # http://www.apache.org/licenses/LICENSE-2.0
# #
# Unless required by applicable law or agreed to in writing, # Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an # software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
@ -15,7 +15,7 @@
# specific language governing permissions and limitations # specific language governing permissions and limitations
# under the License. # under the License.
'''Implements the CloudStack API''' '''Implements the CloudStack API'''
@ -32,7 +32,7 @@ import hashlib
import httplib import httplib
class CloudAPI: class CloudAPI:
@describe("server", "Management Server host name or address") @describe("server", "Management Server host name or address")
@describe("apikey", "Management Server apiKey") @describe("apikey", "Management Server apiKey")
@describe("securitykey", "Management Server securityKey") @describe("securitykey", "Management Server securityKey")
@ -46,14 +46,14 @@ class CloudAPI:
securityKey=None securityKey=None
): ):
self.__dict__.update(locals()) self.__dict__.update(locals())
def _make_request_with_keys(self,command,requests={}): def _make_request_with_keys(self,command,requests={}):
requests["command"] = command requests["command"] = command
requests["apiKey"] = self.apiKey requests["apiKey"] = self.apiKey
requests["response"] = "xml" requests["response"] = "xml"
requests = zip(requests.keys(), requests.values()) requests = zip(requests.keys(), requests.values())
requests.sort(key=lambda x: str.lower(x[0])) requests.sort(key=lambda x: str.lower(x[0]))
requestUrl = "&".join(["=".join([request[0], urllib.quote_plus(str(request[1]))]) for request in requests]) requestUrl = "&".join(["=".join([request[0], urllib.quote_plus(str(request[1]))]) for request in requests])
hashStr = "&".join(["=".join([str.lower(request[0]), urllib.quote_plus(str.lower(str(request[1])))]) for request in requests]) hashStr = "&".join(["=".join([str.lower(request[0]), urllib.quote_plus(str.lower(str(request[1])))]) for request in requests])
@ -70,7 +70,7 @@ class CloudAPI:
requests["response"] = self.responseformat requests["response"] = self.responseformat
requests = zip(requests.keys(), requests.values()) requests = zip(requests.keys(), requests.values())
requests.sort(key=lambda x: str.lower(x[0])) requests.sort(key=lambda x: str.lower(x[0]))
requestUrl = "&".join(["=".join([request[0], urllib.quote_plus(str(request[1]))]) for request in requests]) requestUrl = "&".join(["=".join([request[0], urllib.quote_plus(str(request[1]))]) for request in requests])
hashStr = "&".join(["=".join([str.lower(request[0]), urllib.quote_plus(str.lower(str(request[1])))]) for request in requests]) hashStr = "&".join(["=".join([str.lower(request[0]), urllib.quote_plus(str.lower(str(request[1])))]) for request in requests])
@ -80,7 +80,7 @@ class CloudAPI:
self.connection.request("GET", "/client/api?%s"%requestUrl) self.connection.request("GET", "/client/api?%s"%requestUrl)
return self.connection.getresponse().read() return self.connection.getresponse().read()
def _make_request(self,command,parameters=None): def _make_request(self,command,parameters=None):
'''Command is a string, parameters is a dictionary''' '''Command is a string, parameters is a dictionary'''
@ -90,9 +90,9 @@ class CloudAPI:
else: else:
host = self.server host = self.server
port = 8096 port = 8096
url = "http://" + self.server + "/?" url = "http://" + self.server + "/client/api?"
if not parameters: parameters = {} if not parameters: parameters = {}
if self.apiKey is not None and self.securityKey is not None: if self.apiKey is not None and self.securityKey is not None:
return self._make_request_with_auth(command, parameters) return self._make_request_with_auth(command, parameters)
@ -102,7 +102,7 @@ class CloudAPI:
querystring = urllib.urlencode(parameters) querystring = urllib.urlencode(parameters)
url += querystring url += querystring
f = urllib2.urlopen(url) f = urllib2.urlopen(url)
data = f.read() data = f.read()
if self.stripxml == "true": if self.stripxml == "true":
@ -119,51 +119,51 @@ class CloudAPI:
def load_dynamic_methods(): def load_dynamic_methods():
'''creates smart function objects for every method in the commands.xml file''' '''creates smart function objects for every method in the commands.xml file'''
def getText(nodelist): def getText(nodelist):
rc = [] rc = []
for node in nodelist: for node in nodelist:
if node.nodeType == node.TEXT_NODE: rc.append(node.data) if node.nodeType == node.TEXT_NODE: rc.append(node.data)
return ''.join(rc) return ''.join(rc)
# FIXME figure out installation and packaging # FIXME figure out installation and packaging
xmlfile = os.path.join("/etc/cloud/cli/","commands.xml") xmlfile = os.path.join("/etc/cloud/cli/","commands.xml")
dom = xml.dom.minidom.parse(xmlfile) dom = xml.dom.minidom.parse(xmlfile)
for cmd in dom.getElementsByTagName("command"): for cmd in dom.getElementsByTagName("command"):
name = getText(cmd.getElementsByTagName('name')[0].childNodes).strip() name = getText(cmd.getElementsByTagName('name')[0].childNodes).strip()
assert name assert name
description = getText(cmd.getElementsByTagName('description')[0].childNodes).strip() description = getText(cmd.getElementsByTagName('description')[0].childNodes).strip()
if description: if description:
description = '"""%s"""' % description description = '"""%s"""' % description
else: description = '' else: description = ''
arguments = [] arguments = []
options = [] options = []
descriptions = [] descriptions = []
for param in cmd.getElementsByTagName("request")[0].getElementsByTagName("arg"): for param in cmd.getElementsByTagName("request")[0].getElementsByTagName("arg"):
argname = getText(param.getElementsByTagName('name')[0].childNodes).strip() argname = getText(param.getElementsByTagName('name')[0].childNodes).strip()
assert argname assert argname
required = getText(param.getElementsByTagName('required')[0].childNodes).strip() required = getText(param.getElementsByTagName('required')[0].childNodes).strip()
if required == 'true': required = True if required == 'true': required = True
elif required == 'false': required = False elif required == 'false': required = False
else: raise AssertionError, "Not reached" else: raise AssertionError, "Not reached"
if required: arguments.append(argname) if required: arguments.append(argname)
options.append(argname) options.append(argname)
#import ipdb; ipdb.set_trace() #import ipdb; ipdb.set_trace()
requestDescription = param.getElementsByTagName('description') requestDescription = param.getElementsByTagName('description')
if requestDescription: if requestDescription:
descriptionParam = getText(requestDescription[0].childNodes) descriptionParam = getText(requestDescription[0].childNodes)
else: else:
descriptionParam = '' descriptionParam = ''
if descriptionParam: descriptions.append( (argname,descriptionParam) ) if descriptionParam: descriptions.append( (argname,descriptionParam) )
funcparams = ["self"] + [ "%s=None"%o for o in options ] funcparams = ["self"] + [ "%s=None"%o for o in options ]
funcparams = ", ".join(funcparams) funcparams = ", ".join(funcparams)
code = """ code = """
def %s(%s): def %s(%s):
%s %s
@ -171,7 +171,7 @@ def load_dynamic_methods():
del parms["self"] del parms["self"]
for arg in %r: for arg in %r:
if locals()[arg] is None: if locals()[arg] is None:
raise TypeError, "%%s is a required option"%%arg raise TypeError, "%%s is a required option"%%arg
for k,v in parms.items(): for k,v in parms.items():
if v is None: del parms[k] if v is None: del parms[k]
output = self._make_request("%s",parms) output = self._make_request("%s",parms)
@ -180,15 +180,15 @@ def load_dynamic_methods():
namespace = {} namespace = {}
exec code.strip() in namespace exec code.strip() in namespace
func = namespace[name] func = namespace[name]
for argname,description in descriptions: for argname,description in descriptions:
func = describe(argname,description)(func) func = describe(argname,description)(func)
yield (name,func) yield (name,func)
for name,meth in load_dynamic_methods(): for name,meth in load_dynamic_methods():
setattr(CloudAPI, name, meth) setattr(CloudAPI, name, meth)
implementor = CloudAPI implementor = CloudAPI