From 81a794a5d3def713a5d00b4cff548bab189c2b3b Mon Sep 17 00:00:00 2001 From: Min Chen Date: Thu, 21 Nov 2013 10:32:08 -0800 Subject: [PATCH] Change two static response views to Full and Restricted. --- api/src/org/apache/cloudstack/api/APICommand.java | 2 +- api/src/org/apache/cloudstack/api/ResponseObject.java | 4 ++-- .../cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java | 2 +- .../org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java | 2 +- server/src/com/cloud/api/ApiServer.java | 4 ++-- server/src/com/cloud/api/query/QueryManagerImpl.java | 4 ++-- server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/api/src/org/apache/cloudstack/api/APICommand.java b/api/src/org/apache/cloudstack/api/APICommand.java index 008bd1ed4d8..192d6ad0168 100644 --- a/api/src/org/apache/cloudstack/api/APICommand.java +++ b/api/src/org/apache/cloudstack/api/APICommand.java @@ -40,7 +40,7 @@ public @interface APICommand { String since() default ""; - ResponseView responseView() default ResponseView.Admin; + ResponseView responseView() default ResponseView.Full; RoleType[] authorized() default {}; } diff --git a/api/src/org/apache/cloudstack/api/ResponseObject.java b/api/src/org/apache/cloudstack/api/ResponseObject.java index 6c32016d355..2a3ba9b4849 100644 --- a/api/src/org/apache/cloudstack/api/ResponseObject.java +++ b/api/src/org/apache/cloudstack/api/ResponseObject.java @@ -78,7 +78,7 @@ public interface ResponseObject { void setJobStatus(Integer jobStatus); public enum ResponseView { - Admin, - User + Full, + Restricted } } diff --git a/api/src/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java b/api/src/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java index 5699fbd2afa..489af297b8d 100644 --- a/api/src/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java +++ b/api/src/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java @@ -29,7 +29,7 @@ import org.apache.cloudstack.api.response.StoragePoolResponse; import org.apache.cloudstack.api.response.UserVmResponse; -@APICommand(name = "listVirtualMachines", description = "List the virtual machines owned by the account.", responseObject = UserVmResponse.class, responseView = ResponseView.Admin) +@APICommand(name = "listVirtualMachines", description = "List the virtual machines owned by the account.", responseObject = UserVmResponse.class, responseView = ResponseView.Full) public class ListVMsCmdByAdmin extends ListVMsCmd { public static final Logger s_logger = Logger.getLogger(ListVMsCmdByAdmin.class.getName()); diff --git a/api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java b/api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java index a031c03c1b3..9d9b372a1d8 100644 --- a/api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java +++ b/api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java @@ -42,7 +42,7 @@ import org.apache.cloudstack.api.response.ZoneResponse; import com.cloud.exception.InvalidParameterValueException; -@APICommand(name = "listVirtualMachines", description = "List the virtual machines owned by the account.", responseObject = UserVmResponse.class, responseView = ResponseView.User) +@APICommand(name = "listVirtualMachines", description = "List the virtual machines owned by the account.", responseObject = UserVmResponse.class, responseView = ResponseView.Restricted) public class ListVMsCmd extends BaseListTaggedResourcesCmd { public static final Logger s_logger = Logger.getLogger(ListVMsCmd.class.getName()); diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java index 45a2cba344a..0ed6a683409 100755 --- a/server/src/com/cloud/api/ApiServer.java +++ b/server/src/com/cloud/api/ApiServer.java @@ -887,9 +887,9 @@ public class ApiServer extends ManagerBase implements HttpRequestHandler, ApiSer return cmdList.get(0); else { // determine the cmd class based on calling context - ResponseView view = ResponseView.User; + ResponseView view = ResponseView.Restricted; if (_accountMgr.isRootAdmin(CallContext.current().getCallingAccount().getId())) { - view = ResponseView.Admin; + view = ResponseView.Full; } for (Class cmdClass : cmdList) { APICommand at = cmdClass.getAnnotation(APICommand.class); diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java b/server/src/com/cloud/api/query/QueryManagerImpl.java index 882e4066a17..f55fcd8dee1 100644 --- a/server/src/com/cloud/api/query/QueryManagerImpl.java +++ b/server/src/com/cloud/api/query/QueryManagerImpl.java @@ -737,9 +737,9 @@ public class QueryManagerImpl extends ManagerBase implements QueryService { public ListResponse searchForUserVMs(ListVMsCmd cmd) { Pair, Integer> result = searchForUserVMsInternal(cmd); ListResponse response = new ListResponse(); - ResponseView respView = ResponseView.User; + ResponseView respView = ResponseView.Restricted; if (cmd instanceof ListVMsCmdByAdmin) { - respView = ResponseView.Admin; + respView = ResponseView.Full; } List vmResponses = ViewResponseHelper.createUserVmResponse(respView, "virtualmachine", cmd.getDetails(), result.first().toArray(new UserVmJoinVO[result.first().size()])); diff --git a/server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java b/server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java index 0094638560f..73716654df3 100644 --- a/server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java +++ b/server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java @@ -127,7 +127,7 @@ public class UserVmJoinDaoImpl extends GenericDaoBase implem } userVmResponse.setZoneId(userVm.getDataCenterUuid()); userVmResponse.setZoneName(userVm.getDataCenterName()); - if (view == ResponseView.Admin || ((view == null) && ((caller == null) || (_accountMgr.isRootAdmin(caller.getId()))))) { + if (view == ResponseView.Full || ((view == null) && ((caller == null) || (_accountMgr.isRootAdmin(caller.getId()))))) { userVmResponse.setInstanceName(userVm.getInstanceName()); userVmResponse.setHostId(userVm.getHostUuid()); userVmResponse.setHostName(userVm.getHostName());