From 82f910663385241e56568b0f67416ce370058cca Mon Sep 17 00:00:00 2001 From: Vishesh Date: Thu, 10 Aug 2023 12:34:36 +0530 Subject: [PATCH] Remove powermock from kvm hypervisor plugin (#7818) * Remove powermock from kvm hypervisor plugin * Add @RunWith * Remove unnecessary mocks * Remove commented code --- .../hypervisor/kvm/dpdk/DpdkDriverTest.java | 24 +- .../kvm/resource/BridgeVifDriverTest.java | 3 + .../LibvirtComputingResourceTest.java | 403 ++++++++---------- .../resource/LibvirtDomainXMLParserTest.java | 5 + .../kvm/resource/LibvirtKvmAgentHookTest.java | 19 +- .../kvm/resource/LibvirtSecretDefTest.java | 6 + .../resource/LibvirtStoragePoolDefTest.java | 7 + .../LibvirtStoragePoolXMLParserTest.java | 7 + .../kvm/resource/LibvirtVMDefTest.java | 17 +- .../kvm/resource/LibvirtVifDriverTest.java | 75 ++-- ...GetAutoScaleMetricsCommandWrapperTest.java | 14 +- .../LibvirtMigrateCommandWrapperTest.java | 59 ++- ...bvirtNetworkElementCommandWrapperTest.java | 13 +- .../LibvirtReplugNicCommandWrapperTest.java | 36 +- ...bvirtRevertSnapshotCommandWrapperTest.java | 82 ++-- .../LibvirtScaleVmCommandWrapperTest.java | 57 +-- .../wrapper/LibvirtUtilitiesHelperTest.java | 4 +- .../kvm/storage/KVMPhysicalDiskTest.java | 9 + .../kvm/storage/KVMStorageProcessorTest.java | 206 +++++---- .../kvm/storage/LibvirtStoragePoolTest.java | 7 + .../storage/ScaleIOStorageAdaptorTest.java | 3 + .../kvm/storage/ScaleIOStoragePoolTest.java | 81 ++-- .../storage/ScaleIOStoragePoolTest.java.bkp | 202 +++++++++ .../cloudstack/kvm/ha/KVMHostHATest.java | 2 - .../utils/cryptsetup/CryptSetupTest.java | 4 + .../utils/cryptsetup/KeyFileTest.java | 3 + .../utils/linux/KVMHostInfoTest.java | 40 +- .../cloudstack/utils/linux/MemStatTest.java | 33 +- .../utils/qemu/QemuImgFileTest.java | 6 +- .../org.mockito.plugins.MockMaker | 1 + 30 files changed, 829 insertions(+), 599 deletions(-) create mode 100644 plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ScaleIOStoragePoolTest.java.bkp create mode 100644 plugins/hypervisors/kvm/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker diff --git a/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverTest.java b/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverTest.java index 8401269573d..3e18638361c 100644 --- a/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverTest.java +++ b/plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/dpdk/DpdkDriverTest.java @@ -19,22 +19,22 @@ package com.cloud.hypervisor.kvm.dpdk; import com.cloud.utils.script.Script; +import org.junit.After; import org.junit.Assert; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Matchers; +import org.mockito.MockedStatic; import org.mockito.Mockito; import org.mockito.MockitoAnnotations; -import org.powermock.api.mockito.PowerMockito; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; +import org.mockito.junit.MockitoJUnitRunner; + import java.util.HashMap; import java.util.Map; -@PrepareForTest({ Script.class }) -@RunWith(PowerMockRunner.class) +@RunWith(MockitoJUnitRunner.class) public class DpdkDriverTest { private static final int dpdkPortNumber = 7; @@ -43,14 +43,24 @@ public class DpdkDriverTest { private Map extraConfig; + private MockedStatic