diff --git a/server/src/com/cloud/network/IpAddressManagerImpl.java b/server/src/com/cloud/network/IpAddressManagerImpl.java index 2c54137adcd..17fc3d607ee 100644 --- a/server/src/com/cloud/network/IpAddressManagerImpl.java +++ b/server/src/com/cloud/network/IpAddressManagerImpl.java @@ -1695,6 +1695,7 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage Set availableIps = _networkModel.getAvailableIps(network, requestedIp); if (availableIps == null || availableIps.isEmpty()) { + s_logger.debug("There are no free ips in the network " + network ); return null; } @@ -1707,9 +1708,11 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage if (!isSameCidr) { s_logger.warn("Requested ip address " + requestedIp + " doesn't belong to the network " + network + " cidr"); return null; - } else { - return requestedIp; + } else if (NetUtils.IsIpEqualToNetworkOrBroadCastIp(requestedIp, cidr[0], Integer.parseInt(cidr[1]))) { + s_logger.warn("Requested ip address " + requestedIp + " is equal to the to the network/broadcast ip of the network" + network); + return null; } + return requestedIp; } String result; diff --git a/utils/src/com/cloud/utils/net/NetUtils.java b/utils/src/com/cloud/utils/net/NetUtils.java index 8a351097845..11a483c3f7e 100755 --- a/utils/src/com/cloud/utils/net/NetUtils.java +++ b/utils/src/com/cloud/utils/net/NetUtils.java @@ -1435,4 +1435,26 @@ public class NetUtils { SubnetUtils subnetUtils = new SubnetUtils(cidr); return subnetUtils.getInfo().isInRange(ipAddress); } + + public static Boolean IsIpEqualToNetworkOrBroadCastIp(String requestedIp, String cidr, long size) { + assert (size < 32) : "You do know this is not for ipv6 right? Keep it smaller than 32 but you have " + size; + + long ip = ip2Long(cidr); + long startNetMask = ip2Long(getCidrNetmask(size)); + + long start = (ip & startNetMask); + long end = start; + + end = end >> (32 - size); + + end++; + end = (end << (32 - size)) - 1; + + long reqIp = ip2Long(requestedIp); + if (reqIp == start || reqIp == end) { + return true; + } + return false; + } + }