From 8792070f84db8357ea8245bb080d88a0ad010e1c Mon Sep 17 00:00:00 2001
From: Gregor Riepl <Gregor.Riepl@swisstxt.ch>
Date: Tue, 28 Jan 2020 06:35:15 +0100
Subject: [PATCH] Rethrow takeVMSnapshot() exception instead of returning null
 in VMSnapshotManagerImpl (#3761)

Fixes: #3518
---
 .../main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java b/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
index e2cae0651eb..86357f7700f 100644
--- a/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
@@ -515,7 +515,7 @@ public class VMSnapshotManagerImpl extends MutualExclusiveIdsManagerBase impleme
             return snapshot;
         } catch (Exception e) {
             s_logger.debug("Failed to create vm snapshot: " + vmSnapshotId, e);
-            return null;
+            throw new CloudRuntimeException("Failed to create vm snapshot: " + vmSnapshotId, e);
         }
     }