From 89a07084c55aee97c4ebcbb3e5021e5e4e384d11 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 16:28:37 +0200 Subject: [PATCH] Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random Signed-off-by: Rohit Yadav This closes #416 --- .../cloudstack/framework/transport/TransportAddress.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java b/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java index 4a724fd96fc..99e25b1b1ef 100644 --- a/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java +++ b/framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java @@ -19,7 +19,7 @@ package org.apache.cloudstack.framework.transport; -import java.util.Random; +import java.security.SecureRandom; public class TransportAddress { public final static String LOCAL_SERVICE_NODE = ""; @@ -29,6 +29,7 @@ public class TransportAddress { private int _connectionId = LOCAL_SERVICE_CONNECTION; private String _endpointId; private int _magic; + private final SecureRandom randomGenerator=new SecureRandom(); public TransportAddress(String nodeId, int connectionId, String endpointId) { assert (nodeId != null); @@ -39,7 +40,7 @@ public class TransportAddress { _nodeId = nodeId; _connectionId = connectionId; _endpointId = endpointId; - _magic = new Random().nextInt(); + _magic = randomGenerator.nextInt(); } public TransportAddress(String nodeId, int connectionId, String endpointId, int magic) {