From 8a3a4ab9c0c900f9b6e026a74724b8c94cf006f4 Mon Sep 17 00:00:00 2001 From: Nitin Mehta Date: Mon, 16 Jan 2012 14:29:51 +0530 Subject: [PATCH] bug 13096 Make capacity deletion for pod deletion more robust. Reviewed by : Kishan. --- .../cloud/configuration/ConfigurationManagerImpl.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index efc5db3b0d1..290acd02671 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -739,10 +739,7 @@ public class ConfigurationManagerImpl implements ConfigurationManager, Configura if (!privateIps.isEmpty()) { if (!(_privateIpAddressDao.deleteIpAddressByPod(podId))) { throw new CloudRuntimeException("Failed to cleanup private ip addresses for pod " + podId); - } - - // Delete corresponding capacity record - _capacityDao.removeBy(Capacity.CAPACITY_TYPE_PRIVATE_IP, null, podId, null, null); + } } // Delete link local ip addresses for the pod @@ -760,7 +757,10 @@ public class ConfigurationManagerImpl implements ConfigurationManager, Configura _vlanDao.remove(vlan.getId()); } } - + + // Delete corresponding capacity records + _capacityDao.removeBy(null, null, podId, null, null); + // Delete the pod if (!(_podDao.remove(podId))) { throw new CloudRuntimeException("Failed to delete pod " + podId);