From 90443cdd431940ab7fcdd1b74871a62f4d369998 Mon Sep 17 00:00:00 2001 From: Vishesh Date: Fri, 4 Aug 2023 13:55:58 +0530 Subject: [PATCH] Remove powermock from xenserver hypervisor plugin (#7806) --- .../resource/CitrixResourceBaseTest.java | 60 +++---- .../Xenserver625StorageProcessorTest.java | 157 +++++++++--------- .../xenbase/CitrixRequestWrapperTest.java | 70 ++------ .../wrapper/xenbase/XcpServerWrapperTest.java | 6 +- .../xenbase/XenServer56FP1WrapperTest.java | 4 +- .../xenbase/XenServer56WrapperTest.java | 8 +- .../xenbase/XenServer610WrapperTest.java | 50 +----- .../xenbase/XenServer620SP1WrapperTest.java | 4 +- .../xenbase/XenServer620WrapperTest.java | 4 +- .../org.mockito.plugins.MockMaker | 1 + 10 files changed, 134 insertions(+), 230 deletions(-) create mode 100644 plugins/hypervisors/xenserver/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker diff --git a/plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java b/plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java index 661200f3ffe..27a108779e0 100644 --- a/plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java +++ b/plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java @@ -24,6 +24,7 @@ import java.util.Map; import java.util.Set; import org.apache.xmlrpc.XmlRpcException; +import org.junit.After; import org.junit.Assert; import org.junit.Before; import org.junit.Test; @@ -31,11 +32,9 @@ import org.junit.runner.RunWith; import org.mockito.BDDMockito; import org.mockito.InOrder; import org.mockito.Mock; +import org.mockito.MockedStatic; import org.mockito.Mockito; import org.mockito.Spy; -import org.powermock.api.mockito.PowerMockito; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; import com.cloud.agent.api.StartupStorageCommand; import com.cloud.agent.api.StoragePoolInfo; @@ -52,13 +51,13 @@ import com.xensource.xenapi.Host.Record; import com.xensource.xenapi.PBD; import com.xensource.xenapi.SR; import com.xensource.xenapi.Types.XenAPIException; +import org.mockito.junit.MockitoJUnitRunner; import static com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.PLATFORM_CORES_PER_SOCKET_KEY; import static org.junit.Assert.assertEquals; import static org.mockito.Mockito.doReturn; -@RunWith(PowerMockRunner.class) -@PrepareForTest({Host.class, Script.class, SR.class}) +@RunWith(MockitoJUnitRunner.class) public class CitrixResourceBaseTest { @Spy @@ -87,12 +86,14 @@ public class CitrixResourceBaseTest { final static String publicIp = "10.10.10.10"; final static Integer port = 8080; + MockedStatic hostMocked; + @Before public void beforeTest() throws XenAPIException, XmlRpcException { citrixResourceBase._host.setUuid(hostUuidMock); - PowerMockito.mockStatic(Host.class); - PowerMockito.when(Host.getByUuid(connectionMock, hostUuidMock)).thenReturn(hostMock); + hostMocked = Mockito.mockStatic(Host.class); + hostMocked.when(() -> Host.getByUuid(connectionMock, hostUuidMock)).thenReturn(hostMock); hostRecordMock.softwareVersion = new HashMap<>(); Mockito.when(hostMock.getRecord(connectionMock)).thenReturn(hostRecordMock); @@ -102,25 +103,31 @@ public class CitrixResourceBaseTest { public void testGetPathFilesException() { String patch = citrixResourceBase.getPatchFilePath(); - PowerMockito.mockStatic(Script.class); - Mockito.when(Script.findScript("", patch)).thenReturn(null); - - citrixResourceBase.getPatchFiles(); + try (MockedStatic