From 92815fc9f72af5fb4a0ae93e0f9714909461489e Mon Sep 17 00:00:00 2001 From: Kelven Yang Date: Mon, 6 Dec 2010 11:58:33 -0800 Subject: [PATCH] bug 7228: the exception found in this bug actually does not affect normal function but rather a ugly log message. add some protection to ignore invalid parameter from URL --- .../consoleproxy/ConsoleProxyAjaxHandler.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java b/console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java index 22f8294fbec..1d9aa7fe944 100644 --- a/console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java +++ b/console-proxy/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java @@ -185,10 +185,16 @@ public class ConsoleProxyAjaxHandler implements HttpHandler { public static Map getQueryMap(String query) { String[] params = query.split("&"); Map map = new HashMap(); - for (String param : params) { - String name = param.split("=")[0]; - String value = param.split("=")[1]; - map.put(name, value); + for (String param : params) { + String[] paramTokens = param.split("="); + if(paramTokens != null && paramTokens.length == 2) { + String name = param.split("=")[0]; + String value = param.split("=")[1]; + map.put(name, value); + } else { + if(s_logger.isDebugEnabled()) + s_logger.debug("Invalid paramemter in URL found. param: " + param); + } } return map; }