From 9471797590590313db23e2657d9124e053e681fa Mon Sep 17 00:00:00 2001 From: Kishan Kavala Date: Mon, 23 Dec 2013 16:38:56 +0530 Subject: [PATCH] CLOUDSTACK-5587, CLOUDSTACK-5589: Router version in 2.2.x routers is null. Added null check when comparing min version --- .../network/router/VirtualNetworkApplianceManagerImpl.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java index 6c6481db418..a970af6c059 100755 --- a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java +++ b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java @@ -4074,6 +4074,9 @@ public class VirtualNetworkApplianceManagerImpl extends ManagerBase implements V //Checks if the router is at the required version // Compares MS version and router version private boolean checkRouterVersion(VirtualRouter router){ + if(router.getTemplateVersion() == null){ + return false; + } String trimmedVersion = Version.trimRouterVersion(router.getTemplateVersion()); return (Version.compare(trimmedVersion, _minVRVersion) >= 0); }