diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index 01d5a6e0b7d..923d7846b6f 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -3525,7 +3525,7 @@ public class ConfigurationManagerImpl implements ConfigurationManager, Configura checkForProviders = _networkMgr.listNetworkOfferingServices(offering.getId()); } - addOffering = addOffering && _networkMgr.areServicesEnabledInZone(zoneId, offering.getId(), offering.getTags(), checkForProviders); + addOffering = addOffering && _networkMgr.areServicesEnabledInZone(zoneId, offering, checkForProviders); } if (sourceNatSupported != null) { diff --git a/server/src/com/cloud/network/NetworkManager.java b/server/src/com/cloud/network/NetworkManager.java index 431a9f0977e..3948b3045d3 100755 --- a/server/src/com/cloud/network/NetworkManager.java +++ b/server/src/com/cloud/network/NetworkManager.java @@ -274,7 +274,7 @@ public interface NetworkManager extends NetworkService { List listNetworkOfferingServices(long networkOfferingId); - boolean areServicesEnabledInZone(long zoneId, long networkOfferingId, String tags, List services); + boolean areServicesEnabledInZone(long zoneId, NetworkOffering offering, List services); public Map> getIpToServices(List publicIps, boolean rulesRevoked, boolean includingFirewall); diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index c0044fab0cf..1baa2c79196 100644 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -6040,13 +6040,13 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag } @Override - public boolean areServicesEnabledInZone(long zoneId, long networkOfferingId, String tags, List services) { - long physicalNtwkId = findPhysicalNetworkId(zoneId, tags, null); + public boolean areServicesEnabledInZone(long zoneId, NetworkOffering offering, List services) { + long physicalNtwkId = findPhysicalNetworkId(zoneId, offering.getTags(), offering.getTrafficType()); boolean result = true; List checkedProvider = new ArrayList(); for (Service service : services) { // get all the providers, and check if each provider is enabled - List providerNames = _ntwkOfferingSrvcDao.listProvidersForServiceForNetworkOffering(networkOfferingId, service); + List providerNames = _ntwkOfferingSrvcDao.listProvidersForServiceForNetworkOffering(offering.getId(), service); for (String providerName : providerNames) { if (!checkedProvider.contains(providerName)) { result = result && isProviderEnabledInPhysicalNetwork(physicalNtwkId, providerName); diff --git a/server/test/com/cloud/network/MockNetworkManagerImpl.java b/server/test/com/cloud/network/MockNetworkManagerImpl.java index 5e050eee823..50c130e7c79 100755 --- a/server/test/com/cloud/network/MockNetworkManagerImpl.java +++ b/server/test/com/cloud/network/MockNetworkManagerImpl.java @@ -739,7 +739,7 @@ public class MockNetworkManagerImpl implements NetworkManager, Manager, NetworkS } @Override - public boolean areServicesEnabledInZone(long zoneId, long networkOfferingId, String tags, List services) { + public boolean areServicesEnabledInZone(long zoneId, NetworkOffering offering, List services) { // TODO Auto-generated method stub return false; }