From 9b640085ab19b42e1d062634f244bf10b8cc37b1 Mon Sep 17 00:00:00 2001
From: anthony <anthony@cloud.com>
Date: Thu, 7 Jul 2011 10:15:45 -0700
Subject: [PATCH] bug 10618: fixed NPE

status 10618: resolved fixed
---
 .../src/com/cloud/server/StatsCollector.java  | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/server/src/com/cloud/server/StatsCollector.java b/server/src/com/cloud/server/StatsCollector.java
index 7da47e3a51e..95243cb47a8 100755
--- a/server/src/com/cloud/server/StatsCollector.java
+++ b/server/src/com/cloud/server/StatsCollector.java
@@ -267,16 +267,17 @@ public class StatsCollector {
 	            }
 				
                 List<HostVO> hosts = _hostDao.listSecondaryStorageHosts();
-                ConcurrentHashMap<Long, StorageStats> storageStats = new ConcurrentHashMap<Long, StorageStats>();
-                
-                for (HostVO host : hosts) {
+                ConcurrentHashMap<Long, StorageStats> storageStats = new ConcurrentHashMap<Long, StorageStats>();
+                for (HostVO host : hosts) {
+                    if ( host.getStorageUrl() == null ) {
+                        continue;
+                    }
                     GetStorageStatsCommand command = new GetStorageStatsCommand(host.getStorageUrl());
-        			HostVO ssAhost = _agentMgr.getSSAgent(host);
-        			if( ssAhost == null ) {
-        				s_logger.warn("There is no secondary storage VM for secondary storage host " + host.getName());
-        				continue;
-        			}
-        			
+                    HostVO ssAhost = _agentMgr.getSSAgent(host);
+                    if (ssAhost == null) {
+                        s_logger.warn("There is no secondary storage VM for secondary storage host " + host.getName());
+                        continue;
+                    }
                     long hostId = host.getId();
                     Answer answer = _agentMgr.easySend(ssAhost.getId(), command);
                     if (answer != null && answer.getResult()) {