From 9da29e7f7715668e41b37995f659c3d13fa58dff Mon Sep 17 00:00:00 2001 From: Sheng Yang Date: Tue, 24 Jul 2012 11:42:36 -0700 Subject: [PATCH] CS-15676: Fix NPE when stop non-VPC router --- .../router/VpcVirtualNetworkApplianceManagerImpl.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java index 6ec08824699..7e37b93ba69 100644 --- a/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java +++ b/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java @@ -1283,6 +1283,9 @@ public class VpcVirtualNetworkApplianceManagerImpl extends VirtualNetworkApplian super.finalizeStop(profile, answer); //Mark VPN connections as Disconnected DomainRouterVO router = profile.getVirtualMachine(); - _s2sVpnMgr.markDisconnectVpnConnByVpc(router.getVpcId()); + Long vpcId = router.getVpcId(); + if (vpcId != null) { + _s2sVpnMgr.markDisconnectVpnConnByVpc(vpcId); + } } }