diff --git a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java index 1c3c59bcf30..d854b1a5a40 100644 --- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java +++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java @@ -1576,11 +1576,11 @@ StateListener, Configurable { // for each volume find list of suitable storage pools by calling the // allocators - Set originalAvoidPoolSet = avoid.getPoolsToAvoid(); - if (originalAvoidPoolSet == null) { - originalAvoidPoolSet = new HashSet(); + Set originalAvoidPoolSet = new HashSet<>(); + if (avoid.getPoolsToAvoid() != null) { + originalAvoidPoolSet.addAll(avoid.getPoolsToAvoid()); } - Set poolsToAvoidOutput = new HashSet(originalAvoidPoolSet); + Set poolsToAvoidOutput = new HashSet<>(originalAvoidPoolSet); for (VolumeVO toBeCreated : volumesTobeCreated) { s_logger.debug("Checking suitable pools for volume (Id, Type): (" + toBeCreated.getId() + "," + toBeCreated.getVolumeType().name() + ")"); @@ -1657,12 +1657,6 @@ StateListener, Configurable { DiskOfferingVO diskOffering = _diskOfferingDao.findById(toBeCreated.getDiskOfferingId()); - //FR123 check how is it different for service offering getTagsArray and disk offering's - //if ((vmProfile.getTemplate().getFormat() == Storage.ImageFormat.ISO || toBeCreated.getVolumeType() == Volume.Type.ROOT) - // && vmProfile.getServiceOffering().getTagsArray().length != 0) { - // diskOffering.setTagsArray(Arrays.asList(vmProfile.getServiceOffering().getTagsArray())); - //} - DiskProfile diskProfile = new DiskProfile(toBeCreated, diskOffering, vmProfile.getHypervisorType()); boolean useLocalStorage = false; if (vmProfile.getType() != VirtualMachine.Type.User) {