From a00433ff233a7597a46153abb98de1818ca01e61 Mon Sep 17 00:00:00 2001 From: Prachi Damle Date: Fri, 18 Oct 2013 16:16:28 -0700 Subject: [PATCH] CLOUDSTACK-4895: Management server fails to start because snapshot policy time zones have day light savings Changes: - Calendar throws IllegalArgumentException when the hour of the day happens to be skipped due to DST changes. - Fix will ask Calendar to adjust the time accordingly and get the next closest time --- utils/src/com/cloud/utils/DateUtil.java | 41 ++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/utils/src/com/cloud/utils/DateUtil.java b/utils/src/com/cloud/utils/DateUtil.java index af8904617d9..a6f48665ee9 100644 --- a/utils/src/com/cloud/utils/DateUtil.java +++ b/utils/src/com/cloud/utils/DateUtil.java @@ -148,7 +148,13 @@ public class DateUtil { scheduleTime.set(Calendar.MINUTE, minutes); scheduleTime.set(Calendar.SECOND, 0); scheduleTime.set(Calendar.MILLISECOND, 0); - execDate = scheduleTime.getTime(); + try { + execDate = scheduleTime.getTime(); + } catch (IllegalArgumentException ex) { + scheduleTime.setLenient(true); + execDate = scheduleTime.getTime(); + scheduleTime.setLenient(false); + } // XXX: !execDate.after(startDate) is strictly for testing. // During testing we use a test clock which runs much faster than the real clock // So startDate and execDate will always be ahead in the future @@ -168,7 +174,13 @@ public class DateUtil { scheduleTime.set(Calendar.MINUTE, minutes); scheduleTime.set(Calendar.SECOND, 0); scheduleTime.set(Calendar.MILLISECOND, 0); - execDate = scheduleTime.getTime(); + try { + execDate = scheduleTime.getTime(); + } catch (IllegalArgumentException ex) { + scheduleTime.setLenient(true); + execDate = scheduleTime.getTime(); + scheduleTime.setLenient(false); + } // XXX: !execDate.after(startDate) is strictly for testing. // During testing we use a test clock which runs much faster than the real clock // So startDate and execDate will always be ahead in the future @@ -189,7 +201,13 @@ public class DateUtil { scheduleTime.set(Calendar.MINUTE, minutes); scheduleTime.set(Calendar.SECOND, 0); scheduleTime.set(Calendar.MILLISECOND, 0); - execDate = scheduleTime.getTime(); + try { + execDate = scheduleTime.getTime(); + } catch (IllegalArgumentException ex) { + scheduleTime.setLenient(true); + execDate = scheduleTime.getTime(); + scheduleTime.setLenient(false); + } // XXX: !execDate.after(startDate) is strictly for testing. // During testing we use a test clock which runs much faster than the real clock // So startDate and execDate will always be ahead in the future @@ -213,7 +231,13 @@ public class DateUtil { scheduleTime.set(Calendar.MINUTE, minutes); scheduleTime.set(Calendar.SECOND, 0); scheduleTime.set(Calendar.MILLISECOND, 0); - execDate = scheduleTime.getTime(); + try { + execDate = scheduleTime.getTime(); + } catch (IllegalArgumentException ex) { + scheduleTime.setLenient(true); + execDate = scheduleTime.getTime(); + scheduleTime.setLenient(false); + } // XXX: !execDate.after(startDate) is strictly for testing. // During testing we use a test clock which runs much faster than the real clock // So startDate and execDate will always be ahead in the future @@ -226,7 +250,14 @@ public class DateUtil { throw new CloudRuntimeException("Incorrect interval: "+type.toString()); } - return scheduleTime.getTime(); + try { + return scheduleTime.getTime(); + } catch (IllegalArgumentException ex) { + scheduleTime.setLenient(true); + Date nextScheduledDate = scheduleTime.getTime(); + scheduleTime.setLenient(false); + return nextScheduledDate; + } } public static long getTimeDifference(Date date1, Date date2){