From a2129b29409faaa8609a40784d83cea97e1302ff Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 21:25:35 +0200 Subject: [PATCH] Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method Signed-off-by: Daan Hoogland This closes #446 --- engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java | 1 - 1 file changed, 1 deletion(-) diff --git a/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java b/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java index bbbf7fd4026..9f1eca67022 100644 --- a/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java +++ b/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java @@ -71,7 +71,6 @@ public class VmWorkJobDispatcher extends AdapterBase implements AsyncJobDispatch } work = VmWorkSerializer.deserialize(workClz, job.getCmdInfo()); - assert(work != null); if(work == null) { s_logger.error("Unable to deserialize VM work " + job.getCmd() + ", job info: " + job.getCmdInfo() + ", job origin: " + job.getRelated()); _asyncJobMgr.completeAsyncJob(job.getId(), JobInfo.Status.FAILED, 0, "Unable to deserialize VM work");