From a39bf18bc7eb3c55286ed74aa473e32cbe980ec8 Mon Sep 17 00:00:00 2001 From: Jessica Wang Date: Wed, 10 Sep 2014 15:35:53 -0700 Subject: [PATCH] CLOUDSTACK-7462: UI > Network > VPC > Router > Network ACL Lists > click an entry from list > Details tab > ACL List Rules tab > click Edit icon on any existing rule > fix the JavaScript error "args.jsonObj is undefined". --- ui/scripts/sharedFunctions.js | 68 +++++++++++++++++------------------ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/ui/scripts/sharedFunctions.js b/ui/scripts/sharedFunctions.js index bb2d5965c62..41f5d3aa2c6 100644 --- a/ui/scripts/sharedFunctions.js +++ b/ui/scripts/sharedFunctions.js @@ -2173,42 +2173,42 @@ cloudStack.api = { } }, dataProvider: function(args) { - args.response.success({ - data: args.jsonObj.tags - }); - - /* - var resourceId = args.context[contextId][0].id; - var data = { - resourceId: resourceId, - resourceType: resourceType - }; + if (args.jsonObj != undefined) { + args.response.success({ + data: args.jsonObj.tags + }); + } else { + var resourceId = args.context[contextId][0].id; + var data = { + resourceId: resourceId, + resourceType: resourceType + }; - if (isAdmin() || isDomainAdmin()) { - data.listAll = true; - } - - if (args.context.projects) { - data.projectid = args.context.projects[0].id; - } - - if (args.jsonObj != null && args.jsonObj.projectid != null && data.projectid == null) { - data.projectid = args.jsonObj.projectid; - } - - $.ajax({ - url: createURL('listTags'), - data: data, - success: function(json) { - args.response.success({ - data: json.listtagsresponse ? json.listtagsresponse.tag : [] - }); - }, - error: function(json) { - args.response.error(parseXMLHttpResponse(json)); + if (isAdmin() || isDomainAdmin()) { + data.listAll = true; } - }); - */ + + if (args.context.projects) { + data.projectid = args.context.projects[0].id; + } + + if (args.jsonObj != null && args.jsonObj.projectid != null && data.projectid == null) { + data.projectid = args.jsonObj.projectid; + } + + $.ajax({ + url: createURL('listTags'), + data: data, + success: function(json) { + args.response.success({ + data: json.listtagsresponse ? json.listtagsresponse.tag : [] + }); + }, + error: function(json) { + args.response.error(parseXMLHttpResponse(json)); + } + }); + } } }; }