From ab6c234b6239bb42aff496d03e1aa4cb81504aae Mon Sep 17 00:00:00 2001 From: prachi Date: Tue, 10 Jul 2012 08:18:29 -0700 Subject: [PATCH 1/2] CS 15516: com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1 Reviewed-by: Prachi Changes: Missed on setting the zoneId parameter. --- server/src/com/cloud/upgrade/dao/Upgrade2214to30.java | 1 + 1 file changed, 1 insertion(+) diff --git a/server/src/com/cloud/upgrade/dao/Upgrade2214to30.java b/server/src/com/cloud/upgrade/dao/Upgrade2214to30.java index fb7ad38b655..715337762d6 100755 --- a/server/src/com/cloud/upgrade/dao/Upgrade2214to30.java +++ b/server/src/com/cloud/upgrade/dao/Upgrade2214to30.java @@ -193,6 +193,7 @@ public class Upgrade2214to30 extends Upgrade30xBase implements DbUpgrade { //Clean up any vnets that have no live networks/nics pstmt4 = conn.prepareStatement("SELECT v.id, v.vnet, v.reservation_id FROM `cloud`.`op_dc_vnet_alloc` v LEFT JOIN networks n ON CONCAT('vlan://' , v.vnet) = n.broadcast_uri WHERE v.taken IS NOT NULL AND v.data_center_id = ? AND n.broadcast_uri IS NULL AND n.removed IS NULL"); + pstmt4.setLong(1, zoneId); rsVNet = pstmt4.executeQuery(); while(rsVNet.next()){ Long vnet_id = rsVNet.getLong(1); From 65d43a37da7f507e2dfd96d167013f847a8d319b Mon Sep 17 00:00:00 2001 From: prachi Date: Tue, 10 Jul 2012 10:39:15 -0700 Subject: [PATCH 2/2] CS-15516 com.cloud.utils.exception.CloudRuntimeException: Exception while adding PhysicalNetworks : Caused by: java.sql.SQLException: No value specified for parameter 1 Reviewed-By: Prachi - Same bug in 303 to 304. --- server/src/com/cloud/upgrade/dao/Upgrade303to304.java | 1 + 1 file changed, 1 insertion(+) diff --git a/server/src/com/cloud/upgrade/dao/Upgrade303to304.java b/server/src/com/cloud/upgrade/dao/Upgrade303to304.java index 187a4d4ebf8..08c4697eae2 100644 --- a/server/src/com/cloud/upgrade/dao/Upgrade303to304.java +++ b/server/src/com/cloud/upgrade/dao/Upgrade303to304.java @@ -173,6 +173,7 @@ public class Upgrade303to304 extends Upgrade30xBase implements DbUpgrade { //Clean up any vnets that have no live networks/nics pstmt4 = conn.prepareStatement("SELECT v.id, v.vnet, v.reservation_id FROM `cloud`.`op_dc_vnet_alloc` v LEFT JOIN networks n ON CONCAT('vlan://' , v.vnet) = n.broadcast_uri WHERE v.taken IS NOT NULL AND v.data_center_id = ? AND n.broadcast_uri IS NULL AND n.removed IS NULL"); + pstmt4.setLong(1, zoneId); rsVNet = pstmt4.executeQuery(); while(rsVNet.next()){ Long vnet_id = rsVNet.getLong(1);