diff --git a/server/src/com/cloud/network/NetworkManager.java b/server/src/com/cloud/network/NetworkManager.java index 1c666b0aa7b..5fd931a44e1 100755 --- a/server/src/com/cloud/network/NetworkManager.java +++ b/server/src/com/cloud/network/NetworkManager.java @@ -380,9 +380,9 @@ public interface NetworkManager extends NetworkService { /** * @param vm - * @param network + * @param nic TODO */ - void removeNic(VirtualMachineProfile vm, Network network); + void removeNic(VirtualMachineProfile vm, Nic nic); /** diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index 7f2303dec19..bfaa9c4a0a9 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -2502,9 +2502,8 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag } @Override - public void removeNic(VirtualMachineProfile vm, Network network) { - NicVO nic = _nicDao.findByInstanceIdAndNetworkId(network.getId(), vm.getVirtualMachine().getId()); - removeNic(vm, nic); + public void removeNic(VirtualMachineProfile vm, Nic nic) { + removeNic(vm, _nicDao.findById(nic.getId())); } protected void removeNic(VirtualMachineProfile vm, NicVO nic) { diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java index dc6f00b0973..317cb10a23f 100755 --- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java @@ -2553,7 +2553,7 @@ public class VirtualMachineManagerImpl implements VirtualMachineManager, Listene s_logger.debug("Successfully released nic " + nic + "for vm " + vm); //3) Remove the nic - _networkMgr.removeNic(vmProfile, network); + _networkMgr.removeNic(vmProfile, nic); return result; } diff --git a/server/test/com/cloud/network/MockNetworkManagerImpl.java b/server/test/com/cloud/network/MockNetworkManagerImpl.java index 9a8bf895638..b500e0ccbb5 100755 --- a/server/test/com/cloud/network/MockNetworkManagerImpl.java +++ b/server/test/com/cloud/network/MockNetworkManagerImpl.java @@ -938,7 +938,7 @@ public class MockNetworkManagerImpl implements NetworkManager, Manager, NetworkS * @see com.cloud.network.NetworkManager#removeNic(com.cloud.vm.VirtualMachineProfile, com.cloud.network.Network) */ @Override - public void removeNic(VirtualMachineProfile vm, Network network) { + public void removeNic(VirtualMachineProfile vm, Nic nic) { // TODO Auto-generated method stub }