From ad4c56a11f1ddcc5b6e1af75e138a0fc67faabcc Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Wed, 16 Oct 2024 11:37:31 +0530 Subject: [PATCH] minor refactor for executor min-max Signed-off-by: Abhishek Kumar --- utils/src/main/java/com/cloud/utils/nio/NioConnection.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/utils/src/main/java/com/cloud/utils/nio/NioConnection.java b/utils/src/main/java/com/cloud/utils/nio/NioConnection.java index 66b42b8310a..08c5787dc01 100644 --- a/utils/src/main/java/com/cloud/utils/nio/NioConnection.java +++ b/utils/src/main/java/com/cloud/utils/nio/NioConnection.java @@ -80,7 +80,7 @@ public abstract class NioConnection implements Callable { protected ExecutorService _sslHandshakeExecutor; protected CAService caService; protected Integer sslHandshakeTimeout = null; - private int sslHandshakeMaxWorkers; + private final int sslHandshakeMaxWorkers; private final AtomicInteger activeAcceptConnections = new AtomicInteger(0); private final BlockingQueue workerQueue; private final BlockingQueue sslHandshakeQueue; @@ -92,13 +92,12 @@ public abstract class NioConnection implements Callable { _selector = null; _port = port; _factory = factory; - int sslMinWorkers = Math.max(sslHandshakeMinWorkers, 1); - this.sslHandshakeMaxWorkers = Math.max(sslHandshakeMaxWorkers, sslMinWorkers); + this.sslHandshakeMaxWorkers = Math.max(sslHandshakeMaxWorkers, 1); workerQueue = new LinkedBlockingQueue<>(5 * workers); _executor = new ThreadPoolExecutor(workers, 5 * workers, 1, TimeUnit.DAYS, workerQueue, new NamedThreadFactory(name + "-Handler"), new ThreadPoolExecutor.AbortPolicy()); sslHandshakeQueue = new SynchronousQueue<>(); - _sslHandshakeExecutor = new ThreadPoolExecutor(sslMinWorkers, this.sslHandshakeMaxWorkers, 30, + _sslHandshakeExecutor = new ThreadPoolExecutor(Math.max(sslHandshakeMinWorkers, 0), this.sslHandshakeMaxWorkers, 30, TimeUnit.MINUTES, sslHandshakeQueue, new NamedThreadFactory(name + "-SSLHandshakeHandler"), new ThreadPoolExecutor.AbortPolicy()); }