diff --git a/api/src/com/cloud/api/commands/DeleteVpnConnectionCmd.java b/api/src/com/cloud/api/commands/DeleteVpnConnectionCmd.java index 8b13f4738d9..d08e952a302 100644 --- a/api/src/com/cloud/api/commands/DeleteVpnConnectionCmd.java +++ b/api/src/com/cloud/api/commands/DeleteVpnConnectionCmd.java @@ -100,8 +100,8 @@ public class DeleteVpnConnectionCmd extends BaseAsyncCmd { @Override public void execute(){ try { - Site2SiteVpnConnection result = _s2sVpnService.deleteVpnConnection(this); - if (result != null) { + boolean result = _s2sVpnService.deleteVpnConnection(this); + if (result) { SuccessResponse response = new SuccessResponse(getCommandName()); this.setResponseObject(response); } else { diff --git a/api/src/com/cloud/api/commands/DeleteVpnCustomerGatewayCmd.java b/api/src/com/cloud/api/commands/DeleteVpnCustomerGatewayCmd.java index a244be0b47c..705e62c229b 100644 --- a/api/src/com/cloud/api/commands/DeleteVpnCustomerGatewayCmd.java +++ b/api/src/com/cloud/api/commands/DeleteVpnCustomerGatewayCmd.java @@ -98,8 +98,8 @@ public class DeleteVpnCustomerGatewayCmd extends BaseAsyncCmd { @Override public void execute(){ - Site2SiteCustomerGateway result = _s2sVpnService.deleteCustomerGateway(this); - if (result != null) { + boolean result = _s2sVpnService.deleteCustomerGateway(this); + if (result) { SuccessResponse response = new SuccessResponse(getCommandName()); this.setResponseObject(response); } else { diff --git a/api/src/com/cloud/api/commands/DeleteVpnGatewayCmd.java b/api/src/com/cloud/api/commands/DeleteVpnGatewayCmd.java index 2c9c209168d..34ee1a0ac0b 100644 --- a/api/src/com/cloud/api/commands/DeleteVpnGatewayCmd.java +++ b/api/src/com/cloud/api/commands/DeleteVpnGatewayCmd.java @@ -100,8 +100,8 @@ public class DeleteVpnGatewayCmd extends BaseAsyncCmd { @Override public void execute(){ - Site2SiteVpnGateway result = _s2sVpnService.deleteVpnGateway(this); - if (result != null) { + boolean result = _s2sVpnService.deleteVpnGateway(this); + if (result) { SuccessResponse response = new SuccessResponse(getCommandName()); this.setResponseObject(response); } else { diff --git a/api/src/com/cloud/network/vpn/Site2SiteVpnService.java b/api/src/com/cloud/network/vpn/Site2SiteVpnService.java index f3f188d430c..9a97d976f64 100644 --- a/api/src/com/cloud/network/vpn/Site2SiteVpnService.java +++ b/api/src/com/cloud/network/vpn/Site2SiteVpnService.java @@ -38,9 +38,9 @@ public interface Site2SiteVpnService { Site2SiteVpnConnection startVpnConnection(long id) throws ResourceUnavailableException; IpAddress getVpnGatewayIp(Long vpnGatewayId); Site2SiteVpnConnection createVpnConnection(CreateVpnConnectionCmd cmd) throws NetworkRuleConflictException; - Site2SiteCustomerGateway deleteCustomerGateway(DeleteVpnCustomerGatewayCmd deleteVpnCustomerGatewayCmd); - Site2SiteVpnGateway deleteVpnGateway(DeleteVpnGatewayCmd deleteVpnGatewayCmd); - Site2SiteVpnConnection deleteVpnConnection(DeleteVpnConnectionCmd deleteVpnConnectionCmd) throws ResourceUnavailableException; + boolean deleteCustomerGateway(DeleteVpnCustomerGatewayCmd deleteVpnCustomerGatewayCmd); + boolean deleteVpnGateway(DeleteVpnGatewayCmd deleteVpnGatewayCmd); + boolean deleteVpnConnection(DeleteVpnConnectionCmd deleteVpnConnectionCmd) throws ResourceUnavailableException; Site2SiteVpnConnection resetVpnConnection(ResetVpnConnectionCmd resetVpnConnectionCmd) throws ResourceUnavailableException; List searchForCustomerGateways(ListVpnCustomerGatewaysCmd listVpnCustomerGatewaysCmd); List searchForVpnGateways(ListVpnGatewaysCmd listVpnGatewaysCmd); diff --git a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java index 6b4187e0829..cbae645f44d 100644 --- a/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java +++ b/server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java @@ -183,25 +183,25 @@ public class Site2SiteVpnManagerImpl implements Site2SiteVpnService, Manager { } @Override - public Site2SiteCustomerGateway deleteCustomerGateway(DeleteVpnCustomerGatewayCmd cmd) { + public boolean deleteCustomerGateway(DeleteVpnCustomerGatewayCmd cmd) { Long id = cmd.getId(); Site2SiteCustomerGateway customerGateway = _customerGatewayDao.findById(id); if (customerGateway == null) { throw new InvalidParameterValueException("Fail to find customer gateway with " + id + " !"); } _customerGatewayDao.remove(id); - return customerGateway; + return true; } @Override - public Site2SiteVpnGateway deleteVpnGateway(DeleteVpnGatewayCmd cmd) { + public boolean deleteVpnGateway(DeleteVpnGatewayCmd cmd) { Long id = cmd.getId(); Site2SiteVpnGateway vpnGateway = _vpnGatewayDao.findById(id); if (vpnGateway == null) { throw new InvalidParameterValueException("Fail to find vpn gateway with " + id + " !"); } _vpnGatewayDao.remove(id); - return vpnGateway; + return true; } @Override @@ -252,7 +252,7 @@ public class Site2SiteVpnManagerImpl implements Site2SiteVpnService, Manager { } @Override - public Site2SiteVpnConnection deleteVpnConnection(DeleteVpnConnectionCmd cmd) throws ResourceUnavailableException { + public boolean deleteVpnConnection(DeleteVpnConnectionCmd cmd) throws ResourceUnavailableException { Long id = cmd.getId(); Site2SiteVpnConnectionVO conn = _vpnConnectionDao.findById(id); if (conn == null) { @@ -262,7 +262,7 @@ public class Site2SiteVpnManagerImpl implements Site2SiteVpnService, Manager { stopVpnConnection(id); } _vpnConnectionDao.remove(id); - return conn; + return true; } private void stopVpnConnection(Long id) throws ResourceUnavailableException {