From b0a3f329a0e96da8906f1f3204df67d3905f24c2 Mon Sep 17 00:00:00 2001
From: anthony <anthony@cloud.com>
Date: Mon, 11 Oct 2010 11:59:10 -0700
Subject: [PATCH] bug 6500: add back the special handle for secodary storage
 host, it is in the same path of handling xenserver host, it is easy to break
 that, so I add some comments there

status 6500: resolved fixed
---
 .../cloud/hypervisor/xen/resource/CitrixResourceBase.java   | 5 -----
 server/src/com/cloud/agent/manager/AgentManagerImpl.java    | 6 ++++--
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
index bde092d0483..ca47e3f8bf1 100644
--- a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
+++ b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
@@ -3929,12 +3929,7 @@ public abstract class CitrixResourceBase implements StoragePoolResource, ServerR
             } finally {
                 sshConnection.close();
             }
-            try {
-                // wait 2 seconds before call plugin
-                Thread.sleep(2000);
-            } catch (final InterruptedException ex) {
 
-            }
             if (!setIptables()) {
                 s_logger.warn("set xenserver Iptable failed");
             }
diff --git a/server/src/com/cloud/agent/manager/AgentManagerImpl.java b/server/src/com/cloud/agent/manager/AgentManagerImpl.java
index f2d92ac5350..6c2d0cdca7c 100755
--- a/server/src/com/cloud/agent/manager/AgentManagerImpl.java
+++ b/server/src/com/cloud/agent/manager/AgentManagerImpl.java
@@ -910,10 +910,12 @@ public class AgentManagerImpl implements AgentManager, HandlerFactory {
         
         Long dcId = host.getDataCenterId();
         ReadyCommand ready = new ReadyCommand(dcId);
-        Answer answer = easySend(hostId, ready);
+        Answer answer = easySend(hostId, ready);       
         if (answer == null) {
+            // this is tricky part for secondary storage
+            // make it as disconnected, wait for secondary storage VM to be up
+            // return the attache instead of null, even it is disconnectede
             handleDisconnect(attache, Event.AgentDisconnected, false);
-            return null;
         }
         
         _hostDao.updateStatus(host, Event.Ready, _nodeId);