From b49d681598a4a44e16109efbad90feef13fb435b Mon Sep 17 00:00:00 2001 From: weingartner Date: Mon, 31 Aug 2015 07:51:01 -0300 Subject: [PATCH] Changed the test case to test each of the log traces in the array list. --- .../cloud/utils/log/CglibThrowableRendererTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/utils/src/test/java/com/cloud/utils/log/CglibThrowableRendererTest.java b/utils/src/test/java/com/cloud/utils/log/CglibThrowableRendererTest.java index def65c4d421..ae5d4870432 100644 --- a/utils/src/test/java/com/cloud/utils/log/CglibThrowableRendererTest.java +++ b/utils/src/test/java/com/cloud/utils/log/CglibThrowableRendererTest.java @@ -21,6 +21,7 @@ package com.cloud.utils.log; import java.lang.reflect.Method; +import org.apache.commons.lang.StringUtils; import org.junit.Assert; import org.junit.Test; @@ -39,18 +40,20 @@ public class CglibThrowableRendererTest { sampleClass.theFirstMethodThatCapturesAnException(); } catch (Exception e) { String[] exceptions = cglibThrowableRenderer.doRender(e); - dumpExceptions(exceptions); - Assert.assertEquals(40, exceptions.length); + assertThatTheTraceListDoesNotContainsCgLibLogs(exceptions); } } - private void dumpExceptions(String[] exceptions) { - System.out.println("Dumping exception for debugging purposes"); + private void assertThatTheTraceListDoesNotContainsCgLibLogs(String[] exceptions) { for (String s : exceptions) { - System.out.println(s); + Assert.assertEquals(false, isCgLibLogTrace(s)); } } + private boolean isCgLibLogTrace(String s) { + return StringUtils.contains(s, "net.sf.cglib.proxy"); + } + static class SampleClass { public void theFirstMethodThatCapturesAnException() { try {