From b6aeb6746cffafbb7808e5a1dca290e3872dcef7 Mon Sep 17 00:00:00 2001 From: abhishek Date: Tue, 2 Nov 2010 11:30:43 -0700 Subject: [PATCH] bug 6889: fixing the issue where we were able to create a disk offering of size 0. The check was incorrect, and now we ensure we only create the right sized volumes. status 6889: resolved fixed --- .../src/com/cloud/configuration/ConfigurationManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index 4d77c1bd299..05c1bc3cf39 100644 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -1152,7 +1152,7 @@ public class ConfigurationManagerImpl implements ConfigurationManager { @Override public DiskOfferingVO createDiskOffering(long domainId, String name, String description, int numGibibytes, String tags) throws InvalidParameterValueException { - if ((numGibibytes != 0) && (numGibibytes < 1)) { + if ((numGibibytes <= 0)) { throw new InvalidParameterValueException("Please specify a disk size of at least 1 Gb."); } else if (numGibibytes > _maxVolumeSizeInGb) { throw new InvalidParameterValueException("The maximum size for a disk is " + _maxVolumeSizeInGb + " Gb.");