From b74806929d77683ec51c74498a39c5a55f21ee0c Mon Sep 17 00:00:00 2001 From: Chiradeep Vittal Date: Tue, 7 Sep 2010 17:20:49 -0700 Subject: [PATCH] bug 6099: don't send ingress rules when not enabled --- .../com/cloud/network/security/NetworkGroupManagerImpl.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/server/src/com/cloud/network/security/NetworkGroupManagerImpl.java b/server/src/com/cloud/network/security/NetworkGroupManagerImpl.java index afc5bab16a3..82e4b0ab531 100644 --- a/server/src/com/cloud/network/security/NetworkGroupManagerImpl.java +++ b/server/src/com/cloud/network/security/NetworkGroupManagerImpl.java @@ -684,6 +684,9 @@ public class NetworkGroupManagerImpl implements NetworkGroupManager { @Override @DB public boolean addInstanceToGroups(final Long userVmId, final List groups) { + if (!_enabled) { + return true; + } if (groups != null) { final Set uniqueGroups = new TreeSet(new NetworkGroupVOComparator()); uniqueGroups.addAll(groups); @@ -724,6 +727,9 @@ public class NetworkGroupManagerImpl implements NetworkGroupManager { @Override @DB public void removeInstanceFromGroups(Long userVmId) { + if (!_enabled) { + return; + } final Transaction txn = Transaction.currentTxn(); txn.start(); UserVm userVm = _userVMDao.acquire(userVmId); //ensures that duplicate entries are not created in addInstance