From b74c398d76da1736750a29119c59c239243c3dd6 Mon Sep 17 00:00:00 2001 From: Abhinandan Prateek Date: Wed, 3 Aug 2011 14:41:04 +0530 Subject: [PATCH] domain syntax check for zoneupdate --- .../com/cloud/configuration/ConfigurationManagerImpl.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index e140263377b..5e2cddbbd39 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -1187,6 +1187,13 @@ public class ConfigurationManagerImpl implements ConfigurationManager, Configura // add the domain prefix list to details if not null if (dnsSearchOrder != null){ + for(String dom : dnsSearchOrder){ + if (!NetUtils.verifyDomainName(dom)) { + throw new InvalidParameterValueException( + "Invalid network domain suffixes. Total length shouldn't exceed 190 chars. Each domain label must be between 1 and 63 characters long, can contain ASCII letters 'a' through 'z', the digits '0' through '9', " + + "and the hyphen ('-'); can't start or end with \"-\""); + } + } newDetails.put(ZoneConfig.DnsSearchOrder.getName(), StringUtils.join(dnsSearchOrder, ",")); }