From b8a19e73afe7bd1af10759877d9dceab6f9ef983 Mon Sep 17 00:00:00 2001
From: kishan <kishan@cloud.com>
Date: Tue, 12 Jul 2011 16:41:17 +0530
Subject: [PATCH] bug 6128: Throw exception when applying port forwarding rule
 fails status 6128: resolved fixed

---
 .../com/cloud/network/element/VirtualRouterElement.java    | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/server/src/com/cloud/network/element/VirtualRouterElement.java b/server/src/com/cloud/network/element/VirtualRouterElement.java
index 091ff96521e..f4e1386b1c6 100644
--- a/server/src/com/cloud/network/element/VirtualRouterElement.java
+++ b/server/src/com/cloud/network/element/VirtualRouterElement.java
@@ -55,6 +55,7 @@ import com.cloud.org.Cluster;
 import com.cloud.user.AccountManager;
 import com.cloud.uservm.UserVm;
 import com.cloud.utils.component.Inject;
+import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.vm.DomainRouterVO;
 import com.cloud.vm.NicProfile;
 import com.cloud.vm.ReservationContext;
@@ -175,7 +176,11 @@ public class VirtualRouterElement extends DhcpElement implements NetworkElement,
                 return true;
             }
             
-            return _routerMgr.applyFirewallRules(config, rules);
+            if(!_routerMgr.applyFirewallRules(config, rules)){
+                throw new CloudRuntimeException("Failed to apply firewall rules in network "+config.getId());
+            } else {
+                return true;
+            }
         } else {
             return true;
         }