From bad573168e45e455461d85b229dc7f644980036b Mon Sep 17 00:00:00 2001 From: kishan Date: Tue, 17 Jan 2012 15:08:34 +0530 Subject: [PATCH] Bug 12639: while logging events, hide value for configs containing password string in config name Status 12639: resolved fixed Reviewed-By: Nitin Conflicts: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- .../src/com/cloud/configuration/ConfigurationManagerImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java index a6609504813..c2c892f1f1b 100755 --- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java +++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java @@ -436,7 +436,8 @@ public class ConfigurationManagerImpl implements ConfigurationManager, Configura Long userId = UserContext.current().getCallerUserId(); String name = cmd.getCfgName(); String value = cmd.getValue(); - UserContext.current().setEventDetails(" Name: " + name + " New Value: " + ((value == null) ? "" : value)); + UserContext.current().setEventDetails(" Name: "+name +" New Value: "+ (((name.toLowerCase()).contains("password")) ? "*****" : + (((value == null) ? "" : value)))); // check if config value exists ConfigurationVO config = _configDao.findByName(name); if (config == null) {